Your message dated Fri, 17 Mar 2017 18:04:17 +0000 with message-id <e1coweb-000ejp...@fasolo.debian.org> and subject line Bug#857967: fixed in gitlab 8.13.11+dfsg-6 has caused the Debian Bug report #857967, regarding gitlab: postinst chokes on comments locally added to the configuration files to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 857967: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857967 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: gitlab Version: 8.13.11+dfsg-2 Severity: serious Hi, the postinst uses several export $(cat $conffile) constructs which are very fragile to the file content. This breaks on comments, quoted multi-word strings, and probably many more things. Since adding comments while making local modifications to configuration files is quite common, an innocent change can easily break future updates. Here I just duplicated a line in /etc/gitlab/gitlab-debian.conf and commented out the copy: # DEBIAN_FRONTEND=noninteractive apt-get install gitlab --reinstall Reading package lists... Done Building dependency tree Reading state information... Done 0 upgraded, 0 newly installed, 1 reinstalled, 0 to remove and 6 not upgraded. Need to get 0 B/26.4 MB of archives. After this operation, 0 B of additional disk space will be used. Preconfiguring packages ... (Reading database ... 45601 files and directories currently installed.) Preparing to unpack .../gitlab_8.13.11+dfsg-5_all.deb ... invoke-rc.d: could not determine current runlevel invoke-rc.d: policy-rc.d denied execution of stop. Unpacking gitlab (8.13.11+dfsg-5) over (8.13.11+dfsg-5) ... /var/lib/dpkg/info/gitlab.postrm: 21: export: #gitlab_yml_example: bad variable name dpkg: warning: subprocess old post-removal script returned error exit status 2 dpkg: trying script from the new package instead ... /var/lib/dpkg/tmp.ci/postrm: 21: export: #gitlab_yml_example: bad variable name dpkg: error processing archive /var/cache/apt/archives/gitlab_8.13.11+dfsg-5_all.deb (--unpack): subprocess new post-removal script returned error exit status 2 /var/lib/dpkg/tmp.ci/postrm: 21: export: #gitlab_yml_example: bad variable name dpkg: error while cleaning up: subprocess new post-removal script returned error exit status 2 Errors were encountered while processing: /var/cache/apt/archives/gitlab_8.13.11+dfsg-5_all.deb E: Sub-process /usr/bin/dpkg returned an error code (1) IMO, the correct solution would be * use sourcing ('.') to load the content * explicitly export the variables that need to be exported in the postinst Andreas
--- End Message ---
--- Begin Message ---Source: gitlab Source-Version: 8.13.11+dfsg-6 We believe that the bug you reported is fixed in the latest version of gitlab, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 857...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Pirate Praveen <prav...@debian.org> (supplier of updated gitlab package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Fri, 17 Mar 2017 22:29:40 +0530 Source: gitlab Binary: gitlab Architecture: source Version: 8.13.11+dfsg-6 Distribution: unstable Urgency: medium Maintainer: Debian Ruby Extras Maintainers <pkg-ruby-extras-maintain...@lists.alioth.debian.org> Changed-By: Pirate Praveen <prav...@debian.org> Description: gitlab - git powered software platform to collaborate on code (non-omnibus Closes: 857967 Changes: gitlab (8.13.11+dfsg-6) unstable; urgency=medium . * Improve configuration file parsing by using source (Closes: #857967) Checksums-Sha1: 2e557a4e2608d72e031b5ffa3b765d9471d0b652 2534 gitlab_8.13.11+dfsg-6.dsc 05f6e3be87acef85826f7c125cd83682e7f48f8a 49700 gitlab_8.13.11+dfsg-6.debian.tar.xz db72bd54f7541e939967feb6088ce05f485b5ca2 8319 gitlab_8.13.11+dfsg-6_source.buildinfo Checksums-Sha256: 67e45385e5b688698aff7143a3aa00ba3f520a9cb4da8210b0e4704a60b27ac3 2534 gitlab_8.13.11+dfsg-6.dsc fd98447223782a3b26b077c443edb9cf386d17171426ab43b209209ee2bff120 49700 gitlab_8.13.11+dfsg-6.debian.tar.xz 9ecb8a9eb8b17a809edc339061d316a7d1c1a318a7a2b4dd87ec36b88f2ed1be 8319 gitlab_8.13.11+dfsg-6_source.buildinfo Files: 82d4e330484391ae8a37abf3a019f628 2534 ruby optional gitlab_8.13.11+dfsg-6.dsc 48ca99edfa17582db963524634d53110 49700 ruby optional gitlab_8.13.11+dfsg-6.debian.tar.xz 62ec8784fd224182009392c4398fc9f1 8319 ruby optional gitlab_8.13.11+dfsg-6_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKnl0ri/BUtd4Z9pKzh+cZ0USwioFAljMIKwACgkQzh+cZ0US wiqjqA//QnSlndrTMiKdOQSZSlw7IfDNHHmXvZn4hGhpMWPWFdl5/exHboJER7Ve dJRL9hJ2GO1rOb/QU7x5mjREBSklhHmD34ACWotyrOV693jYlQSo5vnzSS3yxLfl SJh7QEDN57ZkoXgxwklpR6UkxQAeEzUSvh5tDQ+srieTQQSAKmAifyMx5JUr7E5t 8MsXW5nUmm2jBqFJhQG2r5U+hY+Yzy2GoJf50JQym6Zc7gpqt+0UWUkHWFRt7+HH ttz/CO/RTf16CCPM4oo3mfIgIy3bE+qUQH38Ic7qKihKJs0k8tWfMHwFRPQE+T4u 9txFqgdfCrrNke5/c4vOJPAmrd8r+Kha60TZ58i5HIv14lVnEn4VkWaKGuY7QmA1 bHXN/If4a6serHzwWInV0HLUSPFBMyM9Qx00VXnDG/OksWY71kWweKpu/YJWskvJ CEvWzR/6QGxqj4eqxfvdivGqkhJtqA7F1J3Z1f3+5vlbAGYSaGQoWKFY7wqeSafy GF0bYUh/asdJT7c9OMqVGOsrw5JoBqNlHrllyj35DKlDs7XDRJwzzl0s7dUL+QXc A1VuJcwvGaISVTwYOhZ7GOao+shLzjLSMXKWTi2dJxFsxIIPB0y7tP9PtQwbnx48 PaqWNAIMay3bOpSIbNH8h7wEFHaw+cUoquni6l6UtdkvYEQsqhw= =KIWP -----END PGP SIGNATURE-----
--- End Message ---
