On Sun, Mar 12, 2017 at 09:16:46AM +0100, Evgeni Golov wrote: > I went a bit further, droped that code, and migrated the setting > to update-rc.d on upgrade. See attached patchset. > > What do you think?
Looks awesome. Tested all possible variants using both systemd and sysv related commands. Seems to work like expected in all cases. One point: For the d/NEWS file to be actually shipped, at least for me this additional patch was needed: diff --git a/CMakeLists.txt b/CMakeLists.txt index c650e16..c4f500d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -26,7 +26,7 @@ if(USE_ATASMART) endif(USE_ATASMART) install(TARGETS thinkfan DESTINATION sbin) -install(FILES NEWS COPYING README examples/thinkfan.conf.complex +install(FILES NEWS COPYING README debian/NEWS examples/thinkfan.conf.complex examples/thinkfan.conf.simple DESTINATION share/doc/thinkfan) install(FILES thinkfan.1 DESTINATION share/man/man1) Wolfgang
signature.asc
Description: PGP signature