Your message dated Sun, 26 Feb 2017 17:18:52 +0000
with message-id <e1ci2te-0006xr...@fasolo.debian.org>
and subject line Bug#855602: fixed in libnids 1.23-2.1
has caused the Debian Bug report #855602,
regarding libnids: undefined reference to `before' after being rebuilt / on
mips64el
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
855602: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=855602
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: libnids
Version: 1.23-2
Severity: serious
Tags: patch
Hi,
After being rebuilt with a recent toolchain, attempting to link against
libnids gives the error:
> /usr/lib/libnids.so: undefined reference to `before'
> /usr/lib/libnids.so: undefined reference to `after'
Notably mips64el already contains a broken binary in the archive as can
be seen from this build log of dsniff:
https://buildd.debian.org/status/fetch.php?pkg=dsniff&arch=mips64el&ver=2.4b1%2Bdebian-23&stamp=1487505250&raw=0
powerpcspe and ppc64 also seem to be broken.
A patch to fix this was already applied to the package in Ubuntu and
I've attached it for convenience.
Thanks,
James
diff -Nru libnids-1.23/debian/changelog libnids-1.23/debian/changelog
--- libnids-1.23/debian/changelog 2010-07-21 19:23:34.000000000 +0000
+++ libnids-1.23/debian/changelog 2015-12-06 06:16:57.000000000 +0000
@@ -1,3 +1,11 @@
+libnids (1.23-2ubuntu1) xenial; urgency=medium
+
+ * debian/patches/before-after.patch: Fix declarations of before and after
+ functions so that they are defined in util.h, fixing undefined references
+ in libnibs.so.
+
+ -- Logan Rosen <lo...@ubuntu.com> Sun, 06 Dec 2015 01:16:24 -0500
+
libnids (1.23-2) unstable; urgency=high
* Update my email address (closes: #574042).
diff -Nru libnids-1.23/debian/control libnids-1.23/debian/control
--- libnids-1.23/debian/control 2010-07-21 00:14:44.000000000 +0000
+++ libnids-1.23/debian/control 2015-12-06 06:16:58.000000000 +0000
@@ -1,7 +1,8 @@
Source: libnids
Section: libdevel
Priority: optional
-Maintainer: Vasilis Pappas <vpap...@gmail.com>
+Maintainer: Ubuntu Developers <ubuntu-devel-disc...@lists.ubuntu.com>
+XSBC-Original-Maintainer: Vasilis Pappas <vpap...@gmail.com>
Build-Depends: libpcap0.8-dev, libnet1-dev (>= 1.1.2.1), debhelper (>= 5), autotools-dev, pkg-config, libglib2.0-dev
Standards-Version: 3.9.0
diff -Nru libnids-1.23/debian/patches/before-after.patch libnids-1.23/debian/patches/before-after.patch
--- libnids-1.23/debian/patches/before-after.patch 1970-01-01 00:00:00.000000000 +0000
+++ libnids-1.23/debian/patches/before-after.patch 2015-12-06 06:16:16.000000000 +0000
@@ -0,0 +1,52 @@
+Description: fix before and after declarations
+ Fix declarations of before and after functions so that they just happen in the header file to fix undefined references in libnids.so.
+Origin: upstream, http://downloads.sourceforge.net/project/libnids/libnids/1.24/libnids-1.24.tar.gz
+Forwarded: no
+Applied-Upstream: 1.24
+Last-Update: 2015-12-06
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/src/util.c
++++ b/src/util.c
+@@ -29,18 +29,6 @@
+ return ret;
+ }
+
+-inline int
+-before(u_int seq1, u_int seq2)
+-{
+- return ((int)(seq1 - seq2) < 0);
+-}
+-
+-inline int
+-after(u_int seq1, u_int seq2)
+-{
+- return ((int)(seq2 - seq1) < 0);
+-}
+-
+ void
+ register_callback(struct proc_node **procs, void (*x))
+ {
+--- a/src/util.h
++++ b/src/util.h
+@@ -23,8 +23,18 @@
+
+ void nids_no_mem(char *);
+ char *test_malloc(int);
+-inline int before(u_int seq1, u_int seq2);
+-inline int after(u_int seq1, u_int seq2);
++
++static inline int
++before(u_int seq1, u_int seq2)
++{
++ return ((int)(seq1 - seq2) < 0);
++}
++
++static inline int
++after(u_int seq1, u_int seq2)
++{
++ return ((int)(seq2 - seq1) < 0);
++}
+ void register_callback(struct proc_node **procs, void (*x));
+ void unregister_callback(struct proc_node **procs, void (*x));
+
diff -Nru libnids-1.23/debian/patches/series libnids-1.23/debian/patches/series
--- libnids-1.23/debian/patches/series 2010-07-21 00:13:10.000000000 +0000
+++ libnids-1.23/debian/patches/series 2015-12-06 06:11:40.000000000 +0000
@@ -1 +1,2 @@
debian-changes-1.23-2
+before-after.patch
signature.asc
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---
Source: libnids
Source-Version: 1.23-2.1
We believe that the bug you reported is fixed in the latest version of
libnids, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 855...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
James Cowgill <jcowg...@debian.org> (supplier of updated libnids package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 26 Feb 2017 16:25:37 +0000
Source: libnids
Binary: libnids-dev libnids1.21
Architecture: source
Version: 1.23-2.1
Distribution: unstable
Urgency: medium
Maintainer: Vasilis Pappas <vpap...@gmail.com>
Changed-By: James Cowgill <jcowg...@debian.org>
Description:
libnids-dev - IP defragmentation TCP segment reassembly library (development)
libnids1.21 - IP defragmentation TCP segment reassembly library
Closes: 851060 855602
Changes:
libnids (1.23-2.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Fix assembly of TCP streams on armhf by adding -fno-strict-aliasing.
(Closes: #851060)
* Fix use of "inline" with GCC >= 5 which causes undefined references in
applications linked against libnids. (Closes: #855602)
Checksums-Sha1:
1ee590b460fe60caa72cdf928ac22dd85584c00a 1833 libnids_1.23-2.1.dsc
862362c7b124bc19c117cd9d760414d57eacb08a 7220 libnids_1.23-2.1.debian.tar.xz
e116285857730057208c3d071088afe854c80085 6209 libnids_1.23-2.1_source.buildinfo
Checksums-Sha256:
05cb544ff47cf26c082ad3e6d10b89ac45d9705166ba9d3cc93c5e877f0d2ee4 1833
libnids_1.23-2.1.dsc
abc77c0ceb57f8ba8747799b230d7097d16379cd3f1ffed3ff0f2c537a5686da 7220
libnids_1.23-2.1.debian.tar.xz
cfd28989b0a1b555ceec5898b04e8cb6fc85a54b6e689008cfaf3dae8eced22c 6209
libnids_1.23-2.1_source.buildinfo
Files:
7369d208b908c3519299f65804887c0d 1833 libdevel optional libnids_1.23-2.1.dsc
1e18e167a2b6b58e89cc5d6d7505e28e 7220 libdevel optional
libnids_1.23-2.1.debian.tar.xz
466c57648fcb3be93667283244497a30 6209 libdevel optional
libnids_1.23-2.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJIBAEBCgAyFiEE+Ixt5DaZ6POztUwQx/FnbeotAe8FAlizCXcUHGpjb3dnaWxs
QGRlYmlhbi5vcmcACgkQx/FnbeotAe/lAhAApe4ohjbXOsiBuXscHqo6H095X7WO
ZGDw8IK9rwl6Jxp3dSVqO8Zqd3YUZun6HUWfr/uNEjRsNlibHePP732A4eiU9iDh
QEoc6rX3/hU2fVIMHK0bPwOqocqv46KBXBe9AHcb8Vx8j2TDhhiKpIXtzTlAVntv
SVale6vkTbvXiMmklfJwvda5vDoWCTraL9NGArKrp5ZK1bM/cWUVBP33pqeGXlq4
+2wAu3kyQ1eIBe8+F93N1RAo6+2TylzrQed6vjp+8ndVgH7QUoe1WKpsf3A4dUpq
khneqb0VCdmAIig8oMY3vGhMA7GeRG33AarBszS3GKWpKC3KB2LAA4PqHOGkPabX
EyyiOU2R12n1oth5S/pX6Xu2E5k3UWOzRn9JSMYGM4LKvtqfgZDVVvbKABRZTQNZ
RjCBYQeeHOPEAWIcT3eX20gx7AX+MmrI6hk1V7BgS0UQlShyoW4Ob5D0xWbwVyEj
a7C1naHBRmdvO85E/i7jWM2NBj9bPS6KeSikvEqVeCQ2hTVmSBh/HnrfltclHRT2
F1cx9Tr7NAmjie8S0ODZYRx5ja1s0aY06ztdgpapaiLUNIrux3kiWOQYaX+FKtIo
stWmd4un1GyStJ3j+Ng8f86q6pcZfAGsRFgV46CT/hgjIDhS1u1N2O8JWPcmcLsH
6qLpDWFG6DfXWP8=
=/4/H
-----END PGP SIGNATURE-----
--- End Message ---
