Hi!
On 02/07/2017 01:34 PM, Sebastian Andrzej Siewior wrote:
>> However, I'm afraid your patch currently has no chance to get merged into
>> the Debian package as it involves too many changes and will therefore
>> rejected by the release team for Debian Stretch.
>
> as per #854412 it got unblocked. Any reason not to upload it as-is?
If the release team agrees with the changes, it's fine. I did not expect
that they'd approve such large changes at this point in the freeze.
>> Also, your patch contains unrelated changes to the formatting like:
>>
>> @@ -421,23 +394,23 @@
>> # MiNT. But MiNT is downward compatible to TOS, so this should
>> # be no problem.
>> atarist[e]:*MiNT:*:* | atarist[e]:*mint:*:* | atarist[e]:*TOS:*:*)
>> - echo m68k-atari-mint${UNAME_RELEASE}
>> + echo m68k-atari-mint${UNAME_RELEASE}
>> exit ;;
>> atari*:*MiNT:*:* | atari*:*mint:*:* | atarist[e]:*TOS:*:*)
>> echo m68k-atari-mint${UNAME_RELEASE}
>> - exit ;;
>> + exit ;;
>>
>> These changes should be removed, so that your patch contains actual
>> functional changes only. I also recommend splitting your patch up
>> into smaller, logical chunks.
>
> now I understand what you mean. Earlier, while reading it, I though you
> were asking to get them removed because I introduced them. Now I
> understand what you emant.
Ok, any idea where these changes come from?
>> If upstream is dead, I'd suggest put your changes in a repo on github
>> and point the Homepage field of the Debian package to that repo.
> I am not sure whether or not upstream is dead. I would like to get as
> little involved in this as possible and just fix what stops it getting
> into testing. Changing the homepage field + creating a github repo looks
> somehow like asking to become the maintainer.
Where did the new upstream come from then? I'm a bit confused.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaub...@debian.org
`. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
