Your message dated Fri, 13 Jan 2017 15:05:52 +0000
with message-id <e1cs3qo-0009fj...@fasolo.debian.org>
and subject line Bug#836907: fixed in hidapi-cffi 0.2.1-1.1
has caused the Debian Bug report #836907,
regarding src:hidapi-cffi: Missing dependencies on python{3,}-cffi
to be marked as done.This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 836907: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836907 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: src:hidapi-cffi Version: 0.2.1-1 Severity: serious Tags: patch Justification: Policy 7.2 Upstream only declares > setup_requires=['cffi >= 0.8'] But that's insufficient, it actually requires cffi at runtime, the first line is: > from cffi import FFI It's worth noting that in Debian we split the cffi package from the cffi-backend package. We assume that cffi packages are using the out-of-line modes, and they only need the cffi-backend. So, when a package declares cffi in install_requires, we generate a dependency on the cffi-backend package. But this package is using the in-line ABI mode (see [0] for an explanation of the modes). So it will need an explicit dependency on cffi, even if upstream fixes setup.py [0]: https://cffi.readthedocs.io/en/latest/overview.html Patch attached: dependencies.patch Also, I noticed a bunch of things in debian/rules that pybulid can do for you, so there's a second patch: pybulid.patch. SRdiff -Nru hidapi-cffi-0.2.1/debian/control hidapi-cffi-0.2.1/debian/control --- hidapi-cffi-0.2.1/debian/control 2015-06-25 13:35:38.000000000 -0700 +++ hidapi-cffi-0.2.1/debian/control 2016-09-06 22:04:59.000000000 -0700 @@ -7,14 +7,14 @@ Package: python-hidapi Architecture: any -Depends: ${misc:Depends}, ${python:Depends}, libhidapi-hidraw0 | libhidapi-libusb0 +Depends: ${misc:Depends}, ${python:Depends}, libhidapi-hidraw0 | libhidapi-libusb0, python-cffi (>= 0.8) Description: Python bindings for the HID API Python bindings for libhidapi for working with Human Interface Devices such as mouses and keyboards. Package: python3-hidapi Architecture: any -Depends: ${misc:Depends}, ${python3:Depends}, libhidapi-hidraw0 | libhidapi-libusb0 +Depends: ${misc:Depends}, ${python3:Depends}, libhidapi-hidraw0 | libhidapi-libusb0, python3-cffi (>= 0.8) Description: Python bindings for the HID API Python bindings for libhidapi for working with Human Interface Devices such as mouses and keyboards.diff -Nru hidapi-cffi-0.2.1/debian/clean hidapi-cffi-0.2.1/debian/clean --- hidapi-cffi-0.2.1/debian/clean 1969-12-31 16:00:00.000000000 -0800 +++ hidapi-cffi-0.2.1/debian/clean 2016-09-06 22:04:59.000000000 -0700 @@ -0,0 +1 @@ +hidapi_cffi.egg-info/* diff -Nru hidapi-cffi-0.2.1/debian/rules hidapi-cffi-0.2.1/debian/rules --- hidapi-cffi-0.2.1/debian/rules 2015-06-25 13:08:50.000000000 -0700 +++ hidapi-cffi-0.2.1/debian/rules 2016-09-06 22:04:59.000000000 -0700 @@ -1,26 +1,6 @@ #!/usr/bin/make -f -# This file was automatically generated by stdeb 0.8.2 at -# Thu, 09 Oct 2014 22:55:33 +0300 -PYTHONS:=$(shell pyversions -vr) -PYTHON3S:=$(shell py3versions -vr) export PYBUILD_NAME=hidapi + %: dh $@ --with python2,python3 --buildsystem=pybuild - -override_dh_clean: - dh_clean -O--buildsystem=pybuild - rm -rf build - rm -rf __pycache__ - -override_dh_install: - set -e ; for pyvers in $(PYTHONS); do \ - python$$pyvers setup.py install --install-layout=deb \ - --root $(CURDIR)/debian/python-hidapi; \ - done - set -e ; for pyvers in $(PYTHON3S); do \ - python$$pyvers setup.py install --install-layout=deb \ - --root $(CURDIR)/debian/python3-hidapi; \ - done - rm -rf $(CURDIR)/debian/python*-hidapi/usr/lib/python*/dist-packages/*.pth - rm -rf $(CURDIR)/debian/python*-hidapi/usr/lib/python3.*
--- End Message ---
--- Begin Message ---Source: hidapi-cffi Source-Version: 0.2.1-1.1 We believe that the bug you reported is fixed in the latest version of hidapi-cffi, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 836...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Adrian Bunk <b...@debian.org> (supplier of updated hidapi-cffi package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Fri, 13 Jan 2017 15:59:36 +0200 Source: hidapi-cffi Binary: python-hidapi python3-hidapi Architecture: source Version: 0.2.1-1.1 Distribution: unstable Urgency: medium Maintainer: Aigars Mahinovs <aigar...@debian.org> Changed-By: Adrian Bunk <b...@debian.org> Description: python-hidapi - Python bindings for the HID API python3-hidapi - Python bindings for the HID API Closes: 836907 Changes: hidapi-cffi (0.2.1-1.1) unstable; urgency=medium . * Non-maintainer upload. * Add missing dependencies on python{3,}-cffi, patch from Stefano Rivera. (Closes: #836907) Checksums-Sha1: 36ef3a1d302a925464dfc81d5781a75ff5ab8e53 1927 hidapi-cffi_0.2.1-1.1.dsc fec747def68d606d8b1da367ce7e36bd7967289a 2172 hidapi-cffi_0.2.1-1.1.debian.tar.xz Checksums-Sha256: 40528477b47fb6390cd413913a12e4b1cf9f1b43ceeca79260e4af372c108cf6 1927 hidapi-cffi_0.2.1-1.1.dsc 075acb113e52f0c2236e8b564bdd2c64c0db9dbebd8bd19c736fa12abbb19967 2172 hidapi-cffi_0.2.1-1.1.debian.tar.xz Files: 382d412c64b4bae1c3451a0f86c67d5c 1927 python optional hidapi-cffi_0.2.1-1.1.dsc a57073cf6ec8c96b6bf614fb233ea967 2172 python optional hidapi-cffi_0.2.1-1.1.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEOvp1f6xuoR0v9F3wiNJCh6LYmLEFAlh43u8ACgkQiNJCh6LY mLHoBw//XzRLFvp+7hvYNANHPgClB337Hajsp9Vx5/PNuJq8rsfAXCjdiba3LK6i qF8P25kqLFsrYkddQ390j4AmlAV2LXMtAnyqBaplCoWHChUHmJNhIgh1Ck78+qJP 1uEypVz4X/iZUtshyExEiihgtJGlxzwK0ysNPllUy8d9510n+g6vw5rUY2XcAngT IoJlhGjr0D0qz/6MceMCS9tMvAkXfvrdo9cDgRf1CEeVQs93y2RRePYbOxVQc8Hq lUj2+MGMJQx2qyAFtLx/fI5TSxWWAzb2iWFBwnwdx3ZoNaKMdf9AzUjyX4AFYiEE ZGAcebCcsvDyeTj6kvIAUa5oE+VvKOVtO9zLB0LQtIOMh7D7jbnIiGc5nzGJYTxC DydWSyoaADlY6FHgN7zOyQ4X2EufQb4sv6giw2hHTVUgyMC2KPKDWl4B0vIIk84k S2nyBwP/gYVZYU5ZBEFqkpqgWrbdGOhz/519zRR/z4QvAyVBg+QJwPYcs3HW74AA VMgicGGxFdQ7GS+Q7FuqCfZAAbEnGRg3bYNO7WQ0c1GiRiEeOYKwPySYesFt7UMh B+cmZ7gsAKILYT19SpRUdwc0P+lgyMFsI/3JZG6a1XxYEWsp5qnmKPuQXbZrBHNQ /jC9fqCZUVPxkVizcftcmgwysm1k5L1LwthL2MSXyshQrS0yp7o= =XD9x -----END PGP SIGNATURE-----
--- End Message ---
