On Thu, Jan 12, 2017 at 01:35:35PM +0100, John Paul Adrian Glaubitz wrote: > Hi Mike! > > On 01/12/2017 01:30 PM, Mike Hommey wrote: > > It's more subtle than that. Also, firefox and icedove already do an > > autoreconf on their own. > > > > icu.m4 is autoconf m4, iow, m4 with [ and ] as quote characters. Which > > means the [[ and ]] in that expression are replaced with literal [ ] in > > the resulting configure script. Funnily, it doesn't happen for the [ and > > ] after the #, so in the resulting configure script, the sed command > > contains [:space:]*#[[:space:]]*etc. > > > > sed < 4.3 was happy to take [:space:], but sed 4.3 isn't anymore. > > Thanks a lot for the explanation! Appreciated. > > > This should be fixed in next upstream release, in less than two weeks. > > What about Icedove? Should we cherry-pick the patch in this case?
Icedove uses Firefox code base upstream, so it will end up there mechanically. Mike
