Control: tag -1 + patch
Hi,
Liang Guo:
> On Thu, Sep 3, 2015 at 3:00 PM, Chris Lamb <la...@debian.org> wrote:
>> Just as a summary, adding python-six is not complete fix - your package
>> would still not being built from the generated sources.
> spice_codegen.py is called in your build procedure, but not in mine.
I think that's precisely the problem here: whether spice_codegen.py is
called or not depends on details about the build environment, which
means that sometimes we'll be building from the source (preferred form
of modification), and sometimes not.
> I remove spice-common/common/generated* to force build system regenerate
> these files, […]
I think it's the way to go (in addition to adding to Build-deps
whatever the code generation tools need, which you already did).
The attached patch seems to be enough to do so: without it my build
system would use the already generated files, with it it
generates them.
Cheers,
--
intrigeri
>From d0de8fa654f67469c464a18b459c9591b32432c9 Mon Sep 17 00:00:00 2001
From: intrigeri <intrig...@debian.org>
Date: Sat, 31 Dec 2016 15:18:40 +0000
Subject: [PATCH] debian/rules: delete generated files to ensure they're
re-generated from source.
---
debian/rules | 2 ++
1 file changed, 2 insertions(+)
diff --git a/debian/rules b/debian/rules
index 68edba9..cfebeb8 100755
--- a/debian/rules
+++ b/debian/rules
@@ -28,6 +28,8 @@ build-gtk3-stamp:
mkdir build-gtk3
ls |egrep -v '(debian|build-gtk)'|xargs -i cp -r {} build-gtk3/
cp .version .tarball-version build-gtk3/
+ rm build-gtk3/spice-common/common/generated_*
+ rm build-gtk3/spice-common/tests/generated_*
cd build-gtk3 && autoreconf
cd build-gtk3 && ./configure --prefix=/usr --libdir=/usr/lib/$(DEB_HOST_MULTIARCH) \
--enable-smartcard=yes --with-gtk=3.0 --disable-static \
--
2.11.0
