Your message dated Sat, 24 Dec 2016 19:48:23 +0000
with message-id <e1cksip-00010n...@fasolo.debian.org>
and subject line Bug#849142: fixed in diffoscope 66
has caused the Debian Bug report #849142,
regarding test regression in test_dex.test_differences with enjarify >= 1.0.3
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
849142: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849142
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: diffoscope
current version: git HEAD 8dde15f9200094882c26a1cf422556c43ec5d5dc
The test_differences test case fails in the test_dex module when using
enjarify 1.0.3. A downgrade of enjarify to 1.0.2 makes the test pass
again. As enjarify 1.0.3 itself seems to do what its supposed to do, i
think the test diff/output is just too strictly tied to the 1.0.2 output.
If the guess above is actually the case, a possible workaround may be to
expect enjarify to be 1.0.2 and skip the test otherwise.
However we start ending up with too many tests strictly tight to a very
specific toolset version, making a more general approach for multiple
sets more and more important.
cheers,
Levente
Logs:
=================================== FAILURES
===================================
_______________________________ test_differences
_______________________________
differences = [<Difference test1.jar -- test2.jar [<Difference zipinfo
-v {} -- zipinfo -v {} []>, <Difference com/example/MainActiv....class
[<Difference javap -verbose -constants -s -l -private {} -- javap
-verbose -constants -s -l -private {} []>]>]>]
@skip_unless_tools_exist('enjarify', 'zipinfo', 'javap')
@skip_unless_tool_is_at_least('javap', javap_version, '1.8')
def test_differences(differences):
assert differences[0].source1 == 'test1.jar'
assert differences[0].source2 == 'test2.jar'
zipinfo = differences[0].details[0]
classdiff = differences[0].details[1]
assert zipinfo.source1 == 'zipinfo -v {}'
assert zipinfo.source2 == 'zipinfo -v {}'
assert classdiff.source1 == 'com/example/MainActivity.class'
assert classdiff.source2 == 'com/example/MainActivity.class'
expected_diff = open(data('dex_expected_diffs')).read()
found_diff = zipinfo.unified_diff +
classdiff.details[0].unified_diff
> assert expected_diff == found_diff
E assert '@@ -54,15 +5...args_size=1\n' == '@@ -54,15
+54...args_size=1\n'
E Skipping 500 identical leading characters in diff, use -v to show
E Skipping 1284 identical trailing characters in diff, use -v to
show
E - fc227a58
E + bc28236e
E - + 32-bit CRC value (hex): 19c9f64e
E ? ^ ^ ^^^
E + + 32-bit CRC value (hex): 59c3af78
E ? ^ ^^ ^^
E compr
tests/comparators/test_dex.py:57: AssertionError
--- End Message ---
--- Begin Message ---
Source: diffoscope
Source-Version: 66
We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 849...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Chris Lamb <la...@debian.org> (supplier of updated diffoscope package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 24 Dec 2016 19:18:30 +0000
Source: diffoscope
Binary: diffoscope
Architecture: source
Version: 66
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks
<reproducible-bui...@lists.alioth.debian.org>
Changed-By: Chris Lamb <la...@debian.org>
Description:
diffoscope - in-depth comparison of files, archives, and directories
Closes: 848049 849142
Changes:
diffoscope (66) unstable; urgency=medium
.
[ Chris Lamb ]
* Update dex_expected_diffs and test requirement to ensure test compatibility
with enjarify >= 1.0.3. (Closes: #849142)
* Print the detected version in @skip_unless_tool_is_at_least test utility.
.
[ Maria Glukhova ]
* Add detection of order-only difference in plain text format. (Closes:
#848049)
.
[ anthraxx ]
* Add OpenSSH Arch package to Recommends.
Checksums-Sha1:
90f5202c59082bfa9f446c9cb61f785b82537c98 2923 diffoscope_66.dsc
a83d0ae72f61eeb2ac8166b313d7c0d38103f90c 315872 diffoscope_66.tar.xz
Checksums-Sha256:
7a5e88ce749f0b3169e2fdb46b3e6fd5c13df26d6e54762fb73deff281f3ee84 2923
diffoscope_66.dsc
fe41876d0c1889663b963090cc2f30d58e1afe8bb3a16e61118d6ad81deed3f4 315872
diffoscope_66.tar.xz
Files:
da0c63fe0280c90dd49ff0efb54903ea 2923 devel optional diffoscope_66.dsc
fbfb52a82f331a5bd8ebd6ebcbdb45f5 315872 devel optional diffoscope_66.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlhezDEACgkQHpU+J9Qx
Hlg4XxAAwhkGTmPkmIEQ7Gph01RCKCjtkOdjagwDIPE3nBzp0NBjSksbyi8QkY4n
yfjk8bLjX01YRGegqaT0CXLtbsCjsTBabaKgh4X1mKn/51nghuOFChIeQRG/rsA0
/eYLAJAAQ/ag2siEiPoISa5YCWRNLYV8K0JUtJnEKCmqPvVxk5Q8zKFaJqUBO8QV
Om1rV1RBUGb863UUMpOYZCXkaN1gvtv+/u3l4yhr3SyV0cEquh5JiDMLcl27yAlB
7gDw4Nb5UuwkNTlUr+5Fkc5GsTeW3A9lsI61VEQPTqc7zwGRB5LjjMVr2+muGfjR
x9ZNtrDZozjwB/6ufnueVoPIE9sHv4IgXvyU5biSk19oN6ZXYHmw7ekZwXKyI7Rm
zGzfJIkIC7Fu4LL5bsUYD6atjQWpyxwvcFCVFv3wmAhN/sQsUs/V/ljUehfUTnEw
rOloYZdALE8E8TBTMpPXIAJNrnM73wMIOpI1wOrFgYYCTsaSVf/NTLzKZAm7FDXy
JWTM5UXeI8wDT30hvCQCFNxVgEMR3KeR3ipN/YqUWBdlilFU4WAEVlsdReV2PC9t
DpYF69VX0J7+UId+O8frmW9jDwyBpqR3TmnCmd9OL99Oozg595nL+rwX2ZLMCoFU
+m6nBaU9/Q/l8bEKcjnXoSncsbHtuJ0la4RqTr20opEiRLRSAQM=
=M1F+
-----END PGP SIGNATURE-----
--- End Message ---
