Control: severity -1 minor
On Tue, Dec 06, 2016 at 07:26:17PM +0200, Adrian Bunk wrote:
> Control: reassign 846019 src:wxwidgets3.0
> Control: forcemerge -1 846019
> Control: severity -1 serious
> Control: affects -1 pgadmin3
>
> After looking at #846019 this appears to be pretty RC.
#846019 looks to be something different - it's giving a *FATAL* error there
(it's not obvious to me how or why since the two strings seem to match aside
from the ABI and I've not had time to try to reproduce yet), but that means it
would not be helped by the proposed patch, since it's not invoking the warning
case but dropping through to the fatal error code below.
I also don't have the time right now to work out how to undo the unhelpful
forcemerge you've just done, so for now I'm just setting the severity back to
the appropriate one for #844486. If you know how to cleanly revert a
forcemerge, please do.
As for the proposed patch, I'm not wild about just removing this warning - the
current patch we're applying downgrades the fatal error to a warning so that
there's a hint as to what's going on if there are problems caused by the
compler ABI change. Remove that will make it much harder to debug any
such cases, and risks annoying wx upstream with bug reports. If people
are finding the current wording too scary, we could reword it.
Cheers,
Olly
