On 12/06/2016 01:25 PM, Marco Innocenti wrote: > Package: monit > Version: 1:5.4-2+deb7u1 > Severity: grave > Justification: renders package unusable > > Dear Maintainer, > after upgrading monit to version 1:5.4-2+deb7u1 monit stopped > working in all the servers we maintain. Reverting back to 1:5.4-2 > solved our problem. > We see a segfault after a stop or a start command. Status is working as > usual. > > root@didanet19:~# monit status | tail > > System 'system_didanet19.private.cineca.it' > status Running > monitoring status Monitored > load average [0.04] [0.13] [0.10] > cpu 4.0%us 0.3%sy 0.0%wa > memory usage 3918168 kB [23.7%] > swap usage 0 kB [0.0%] > data collected Tue, 06 Dec 2016 13:20:36 > > root@didanet19:~# monit stop system_didanet19.private.cineca.it > Segmentation fault > root@didanet19:~# monit start system_didanet19.private.cineca.it > Segmentation fault > > > root@didanet19:~# grep monit /var/log/messages > Dec 6 13:10:12 didanet19 kernel: [4764451.817749] monit[26940]: segfault at > e ip 00007f0b74faba6a sp 00007fff5da8ce80 error 4 in > libc-2.13.so[7f0b74f66000+184000] > Dec 6 13:10:20 didanet19 kernel: [4764459.757404] monit[26941]: segfault at > c ip 00007fe2afe78a6a sp 00007ffc400517f0 error 4 in > libc-2.13.so[7fe2afe33000+184000] > Dec 6 13:10:24 didanet19 kernel: [4764463.479828] monit[26942]: segfault at > b ip 00007fd7e1acda6a sp 00007fff322b8f60 error 4 in > libc-2.13.so[7fd7e1a88000+184000] > Dec 6 13:20:55 didanet19 kernel: [4765093.487700] monit[28100]: segfault at > b ip 00007f99d7141a6a sp 00007ffdb8bef4d0 error 4 in > libc-2.13.so[7f99d70fc000+184000] > Dec 6 13:21:00 didanet19 kernel: [4765099.141708] monit[28101]: segfault at > c ip 00007effe0eaba6a sp 00007fffdce03b50 error 4 in > libc-2.13.so[7effe0e66000+184000] >
Yes, I just notice the security update is broken. I have prepared the fix for this and I was planing to contact the security team about this. Thanks for reporting, Victor Seva
From ee30a7dff71a579d32c6744c38834a5808b10c3f Mon Sep 17 00:00:00 2001
From: Victor Seva <linuxman...@torreviejawireless.org>
Date: Tue, 6 Dec 2016 10:40:19 +0100
Subject: [PATCH] fix 09_CVE-2016-7067.patch producing Segmentation fault on
action
---
debian/changelog | 8 ++++++++
debian/patches/10_fixCVE-2016-7067.patch | 17 +++++++++++++++++
debian/patches/series | 1 +
3 files changed, 26 insertions(+)
create mode 100644 debian/patches/10_fixCVE-2016-7067.patch
diff --git a/debian/changelog b/debian/changelog
index 36b8e78..41ff485 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+monit (1:5.4-2+deb7u2) wheezy-security; urgency=medium
+
+ * Non-maintainer upload.
+ * fix 09_CVE-2016-7067.patch producing Segmentation fault
+ on action
+
+ -- Victor Seva <vs...@debian.org> Tue, 06 Dec 2016 10:29:16 +0100
+
monit (1:5.4-2+deb7u1) wheezy-security; urgency=high
* Non-maintainer upload by the LTS Team.
diff --git a/debian/patches/10_fixCVE-2016-7067.patch b/debian/patches/10_fixCVE-2016-7067.patch
new file mode 100644
index 0000000..32ff6af
--- /dev/null
+++ b/debian/patches/10_fixCVE-2016-7067.patch
@@ -0,0 +1,17 @@
+--- a/src/control.c
++++ b/src/control.c
+@@ -125,12 +125,13 @@ int control_service_daemon(const char *S
+ "Content-Length: %d\r\n"
+ "%s"
+ "\r\n"
+- "action=%s",
+ "securitytoken=%s&action=%s",
+ S,
+ token,
++ strlen("securitytoken=") + strlen(token) + 1 +
+ strlen("action=") + strlen(action),
+ auth ? auth : "",
++ token,
+ action) < 0)
+ {
+ LogError("%s: Cannot send the command '%s' to the monit daemon -- %s", prog, action ? action : "null", STRERROR);
diff --git a/debian/patches/series b/debian/patches/series
index 6116d00..c5ea434 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -3,3 +3,4 @@
07_spelling.patch
08_hide_low_priority_info_from_stderr.patch
09_CVE-2016-7067.patch
+10_fixCVE-2016-7067.patch
--
2.10.2
signature.asc
Description: OpenPGP digital signature
