Hello Andreas, Thank you for reporting these issues. My comments are inline:
On Thu, Nov 10, 2016 at 9:20 AM, Andreas Beckmann <a...@debian.org> wrote: > Package: ifupdown2 > Version: 1.0~git20161101-1 > Severity: serious > > Hi, > > ifupdown doesn't use the diversions correctly > > 1. diverting conffiles does not work well, so just use Breaks against > the bash-completion versions shipping the ifup etc. completion in /etc > Do not forget to clean up the now obsolete diversions in /etc in the > preinst or postinst! > I don't really know how to use breaks and I think we are fine today with diverting. We are now cleaning up /etc/bash_completion.d/ifup (if previously installed by ifupdown2). I used dpkg-maintscript-helper, it seemed to me the ideal way. > 2. unconditionally install the diversions, installing bash-completion > after ifupdown2 breaks right now with a file overwrite error since the > diversions are not in place (this is how I noticed the problems) > I tried to reinstall bash-completion, didn't see any issue. Then remove + install, didn't see any issues. Can you please provide me the steps you are following? > (also upgrading ifupdown2 will suddenly install more diversions since > it finds more of the files that could be diverted - because the > installed ifupdown2 version shipped them) > fixed > > 3. unconditionally install/remove the diversions without checking > whether they exist, running dpkg-divert multiple times is idempotent > I used dpkg-divert --list to check if ifupdown2 owns diversions before removing diversions. We just submitted a debian release. It might get uploaded over the weekend or sometimes next week, I can't give you an exact timeline here. If you wish to have these patches today, I invite you to get them from our github repository (branch debian-prep2): https://github. com/CumulusNetworks/ifupdown2/tree/debian-prep2 git clone https://github.com/CumulusNetworks/ifupdown2.git -b debian-prep2 Thanks again. Regards, Julien.
