On 2016-08-30 12:40:12 [+0200], Gert Wollny wrote: > > Am Dienstag, den 30.08.2016, 08:51 +0200 schrieb Kurt Roeckx: > > On Tue, Jun 28, 2016 at 09:53:20PM +0200, Gert Wollny wrote: > > > > > > Thanks for the review. > > Can I ask what the current state of this is? > > IIRC the last patch applies properly and compiles with openssl 1.0 and > 1.1, but since the package doesn't run a test suite at build time I > have no Idea whether it breaks functionality or not. > > As I pointed out before, I'm neither anopenssl nor a Qt expert, so > additional reviews of the patch would probably be sensible.
I've been looking at the patch [0]. It all looks good to me. Most of the stuff is 1:1 replacement for the accessors. The locking stuff is gone because the new pthread model that is used renders it unnecessary. cipher->valid check in resetDefaultCiphers() can be skipped because openssl returns only valid ciphers not alias ciphers (those have ->valid set to 0 and are ciphers like "ECDHE" which contain all ciphers that have something to do with ECDHE but is not an actuall cipher). So it all looks good to me. resetDefaultCiphers() tries to add all "openssl DEFAULT" ciphers to its internal list except for the anonymous DH cipher. Those are not part of the DEFAULT suite (atleast for 1.0.2 & 1.1.0). abigail reports no ABI change. One thing that confuses me: Why has none of the libraries a dependency on libssl? [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=828522#91 > Best, > Gert Sebastian
