Bug#811846: #811846: status?

[Pino Toscano]

tag 811846 + patch
thanks

In data domenica 18 settembre 2016 19:15:50 CEST, John Paul Adrian Glaubitz ha 
scritto:
> On 09/18/2016 01:07 PM, John Paul Adrian Glaubitz wrote:
> > Sorry guys, was busy this weekend. Will look at it in a few hours :).
> 
> There are two issues with the package on mentors that I see:

Looking further at this very issue (#811846), I don't think the
solution implemented is actually the correct one:

https://anonscm.debian.org/cgit/collab-maint/xbase64.git/commit/?id=39d6239543df5dff1707e14e129574ac393325af

This just forces the C++ dialect to C++98, but that's only a workaround;
looking at the build log in this bug (which can be produced also by
rebuilding xbase64 in an up-to-date unstable/testing environment),
there is a real bug in xbase64/xblock.cpp:

  std::cout << "xbLock constructor" << std::cout;

std::cout is clearly wrong at the end, where std::endl is most probably
what should be used; there are 5 occurrences of this in xbase64, all of
them in xblock.cpp.

Attached there is an actual patch fixing the issue: please integrate it,
and remove the -std=c++98 workaround.

Thanks,
-- 
Pino Toscano
--- a/xbase64/xblock.cpp
+++ b/xbase64/xblock.cpp
@@ -84,7 +84,7 @@ xbLock::xbLock(xbDbf * pdbf)
   TableLockCnt = 0;
   MemoLockCnt  = 0;
   IndexLockCnt = 0;
-  std::cout << "xbLock constructor" << std::cout;
+  std::cout << "xbLock constructor" << std::endl;
 }
 /*************************************************************************/
 xbLock::~xbLock()
@@ -169,7 +169,7 @@ else if( LockType == XB_LOCK || LockType
 /*************************************************************************/
 xbaseLock::xbaseLock( xbDbf * pdbf ) : xbLock( pdbf )
 {
-  std::cout << "xbaseLock constructor" << std::cout;
+  std::cout << "xbaseLock constructor" << std::endl;
 }
 /*************************************************************************/
 xbShort xbaseLock::LockTableHeader( xbShort LockType )
@@ -336,7 +336,7 @@ xbShort xbaseLock::LockInit()
 /*************************************************************************/
 dbaseLock::dbaseLock( xbDbf * pdbf ) : xbLock( pdbf )
 {
-  std::cout << "dbaseLock constructor" << std::cout;
+  std::cout << "dbaseLock constructor" << std::endl;
 }
 /*************************************************************************/
 xbShort dbaseLock::LockTableHeader( xbShort LockType )
@@ -460,7 +460,7 @@ xbShort dbaseLock::UnlockAll()
 /*************************************************************************/
 clipperLock::clipperLock( xbDbf * pdbf ) : xbLock( pdbf )
 {
-  std::cout << "clipperLock constructor" << std::cout;
+  std::cout << "clipperLock constructor" << std::endl;
 }
 /*************************************************************************/
 xbShort clipperLock::LockTableHeader( xbShort LockType )
@@ -523,7 +523,7 @@ xbShort clipperLock::UnlockAll()
 /*************************************************************************/
 foxproLock::foxproLock( xbDbf * pdbf ) : xbLock( pdbf )
 {
-  std::cout << "foxproLock constructor" << std::cout;
+  std::cout << "foxproLock constructor" << std::endl;
 }
 /*************************************************************************/
 xbShort foxproLock::LockTableHeader( xbShort LockType )

signature.asc
Description: This is a digitally signed message part.