Your message dated Thu, 11 Aug 2016 16:23:08 +0000
with message-id <e1bxsla-0006d3...@franck.debian.org>
and subject line Bug#833449: fixed in google-mock 1.7.0-18092013-2.1
has caused the Debian Bug report #833449,
regarding Tests crashes when verifying mock functions calls with gcc-6
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
833449: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=833449
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: google-mock
Version: 1.7.0-18092013-2
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu yakkey
The fix provided for bug #812289 doesn't fix all the cases.
In Ubunutu we use google-mocks in unity and when using gcc-6, things
doesn't work well when mocking some function.
Starting program:
/tmp/unity-7.5.0+16.10.20160804/obj-x86_64-linux-gnu/tests/test-gtest
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7fffe0f1d700 (LWP 22778)]
[New Thread 0x7fffdbfff700 (LWP 22779)]
[New Thread 0x7fffdb7fe700 (LWP 22780)]
[==========] Running 1637 tests from 105 test cases.
[----------] Global test environment set-up.
[----------] 14 tests from TestActionLink
[ RUN ] TestActionLink.AligmentCorrectlySetDifferent
Thread 1 "test-gtest" received signal SIGSEGV, Segmentation fault.
testing::internal::FunctionMockerBase<void ()>::InvokeWith(std::tuple<>
const&) (args=empty std::tuple, this=0x7fffffffdb08)
at /usr/include/gmock/gmock-spec-builders.h:1530
1530 this->UntypedInvokeWith(&args))->GetValueAndDelete();
#0 testing::internal::FunctionMockerBase<void
()>::InvokeWith(std::tuple<> const&) (args=empty std::tuple,
this=0x7fffffffdb08)
at /usr/include/gmock/gmock-spec-builders.h:1530
No locals.
#1 testing::internal::FunctionMocker<void ()>::Invoke()
(this=0x7fffffffdb08) at
/usr/include/gmock/gmock-generated-function-mockers.h:76
No locals.
#2 unity::dash::ActionLinkMock::QueueDraw (this=0x7fffffffd3c0) at
/tmp/unity-7.5.0+16.10.20160804/tests/test_action_link.cpp:43
No locals.
#3 0x00005555559ce574 in unity::dash::ActionLink::set_underline
(this=0x7fffffffd3c0, underline=unity::StaticCairoText::NUX_UNDERLINE_NONE)
at
/tmp/unity-7.5.0+16.10.20160804/tests/../dash/previews/ActionLink.cpp:218
No locals.
#4 0x00005555559d53bf in std::function<bool
(unity::StaticCairoText::UnderlineState
const&)>::operator()(unity::StaticCairoText::UnderlineState const&)
const (__args#0=<optimized out>, this=0x7fffffffda00) at
/usr/include/c++/6/functional:2136
No locals.
#5 nux::RWProperty<unity::StaticCairoText::UnderlineState>::Set
(this=0x7fffffffd9c8, value=<optimized out>)
at /usr/include/Nux-4.0/NuxCore/Property-inl.h:218
No locals.
#6 0x00005555559d0c31 in
unity::dash::TestActionLink_UnderlineCorrectlySetDifferent_Test::TestBody
(this=<optimized out>)
at /tmp/unity-7.5.0+16.10.20160804/tests/test_action_link.cpp:116
The change provided at
https://github.com/google/googletest/issues/705#issuecomment-235067917
and attached here is enough to entirely fix this issue.
Fix for ubuntu, with provided debdiff is http://pad.lv/1609793
Author: Romain Geissler
Origin: https://github.com/google/googletest/issues/705#issuecomment-235067917
Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812289
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/google-mock/+bug/1609793
Forwarded: not-needed
--- a/include/gmock/gmock-spec-builders.h
+++ b/include/gmock/gmock-spec-builders.h
@@ -1370,6 +1370,8 @@
template <>
class ActionResultHolder<void> : public UntypedActionResultHolderBase {
public:
+ explicit ActionResultHolder() {}
+
void GetValueAndDelete() const { delete this; }
virtual void PrintAsActionResult(::std::ostream* /* os */) const {}
@@ -1381,7 +1383,7 @@
const typename Function<F>::ArgumentTuple& args,
const string& call_description) {
func_mocker->PerformDefaultAction(args, call_description);
- return NULL;
+ return new ActionResultHolder();
}
// Performs the given action and returns NULL.
@@ -1390,7 +1392,7 @@
const Action<F>& action,
const typename Function<F>::ArgumentTuple& args) {
action.Perform(args);
- return NULL;
+ return new ActionResultHolder();
}
};
--- End Message ---
--- Begin Message ---
Source: google-mock
Source-Version: 1.7.0-18092013-2.1
We believe that the bug you reported is fixed in the latest version of
google-mock, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 833...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Iain Lane <i...@orangesquash.org.uk> (supplier of updated google-mock package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 04 Aug 2016 15:37:37 +0100
Source: google-mock
Binary: google-mock
Architecture: amd64 source
Version: 1.7.0-18092013-2.1
Distribution: unstable
Urgency: medium
Maintainer: Fredrik Hallenberg <hal...@debian.org>
Changed-By: Iain Lane <i...@orangesquash.org.uk>
Closes: 833449
Launchpad-Bugs-Fixed: 1609793
Description:
google-mock - Google's framework for writing and using C++ mock classes
Changes:
google-mock (1.7.0-18092013-2.1) unstable; urgency=medium
.
* Non-maintainer upload.
* The previous upload fixed google-mock for its own testsuite, but not for
client projects. Backport a patch from an upstream issue to modify some
functions to not return NULL, working around the problem caused for
google-mock itself and for its clients. (Closes: #833449) (LP: #1609793)
* This means we don't need -fno-delete-null-pointer-checks any more, so
remove that workaround.
Checksums-Sha1:
407dc3fbddd90330565c678601708ea390e55150 1867
google-mock_1.7.0-18092013-2.1.dsc
aa51e19c8a6775b9a4eb107654f31b7a790ee64f 6056
google-mock_1.7.0-18092013-2.1.debian.tar.xz
b76fa8e8c93982a3baba639acde1198736c59dd4 118204
google-mock_1.7.0-18092013-2.1_amd64.deb
Checksums-Sha256:
4ab9d489f0621d620c96dc5f090253418cb53a30dac26901f8ddd3252b2da409 1867
google-mock_1.7.0-18092013-2.1.dsc
013a37119c03f001cf2bd6200bd9eac535bbaa3855ece0f983472c3bd7a31d54 6056
google-mock_1.7.0-18092013-2.1.debian.tar.xz
579d9dae6315411e2f3b971092b10b815b0a727e93a09a9c1568c4c9d8dbe6b7 118204
google-mock_1.7.0-18092013-2.1_amd64.deb
Files:
9e74c6b68df9f4b468af556a55407104 1867 devel optional
google-mock_1.7.0-18092013-2.1.dsc
a3a3e99f730c95573e1a644ecd5a8b46 6056 devel optional
google-mock_1.7.0-18092013-2.1.debian.tar.xz
fb6047ffff05c9ce473b87f99eaa532a 118204 devel optional
google-mock_1.7.0-18092013-2.1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCgAGBQJXo1h7AAoJEONS1cUcUEHUC38P/2q4GTuYh9s3lsSBot9Te1/y
d5RmmvmM0349XMlPceAfB3NMPOe84jyvjXYKdN0x6A63Xje4rVzKXOTFH8jAqZXd
E2coNvikC/3fG7ax7OoilMwdG4OZre5PwjZ+csD4sFHwM0+b6zbFX+R5cL8i920o
gZebP7N3nuntmLXgb00OOhAF9gF44OOC75pHn0oREv+DTFB8Gpw516ZllBGgiHHP
/cK/6KdLBuACNCCQyzqXAgDoMieFbEM4/xtTtGv5Gilm53lLdsWDIcTCK8Ro85hs
ursaPUGXhtXloxOt2f4EFQlJ4rjtYE3c8jZ19E73SYHawjsPV/V7sHzfo3iIMnP3
TeJZmL2titjs68IxctSVlavrc3SBqC4Nq9vKvKBy/lNnBRIXyDiR67COEOadQ7Z5
YRdalZ7z3u5ypXOO6P5qzI1HbJb+oKZRMQzK5Kg7XOYfzsekJjFjhlfUMThG82W+
AkW6q6vaZwtAS2YuOni0GeG10SuwJh6Ofr1VOpWkcTccw9XtDHd2cKn4o5H6P4HO
BWADBMXu8rJkTli5QTzHdmQh809CYBkVK0619pyVLh//Ewh1AUiQJYiMY3hSsT/l
dwpSCkS7aZQW/3Gu2Vc9nutcREPUh2zm41PX3iV0EmrlISG3AcS82I7swvVBj9px
x5o4sZU39zFpNhf8k+tS
=xZtF
-----END PGP SIGNATURE-----
--- End Message ---
