Your message dated Sun, 17 Jul 2016 22:29:20 +0000
with message-id <e1bouyq-0000to...@franck.debian.org>
and subject line Bug#830521: fixed in nvme-cli 0.8-2
has caused the Debian Bug report #830521,
regarding nvme-cli: Fix regression in nvme-cli 32-bit compatibility
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
830521: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=830521
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: nvme-cli
Version: 0.8-1
Severity: serious
Tags: patch
Justification: FTBFS
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu yakkety ubuntu-patch
Hi Breno,
After syncing nvme-cli 0.8-1 into Ubuntu yakkety, I noticed that it has
failed to build on all of our 32-bit architectures, with a common error:
cc -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -g -O2 -fPIE
-fstack-protector-strong -Wformat -Werror=format-security -std=gnu99 -O2 -g
-Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8"' -c intel-nvme.c
intel-nvme.c: In function ‘get_internal_log’:
intel-nvme.c:310:13: error: cast from pointer to integer of different size
[-Werror=pointer-to-int-cast]
cmd.addr = (__u64)(void *)buf;
^
cc1: all warnings being treated as errors
Makefile:44: recipe for target 'intel-nvme.o' failed
I've applied the attached patch in Ubuntu to address this. Please consider
applying this patch in Debian as well, and forward upstream as necessary.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru nvme-cli-0.8/debian/patches/32-bit-compatibility.patch nvme-cli-0.8/debian/patches/32-bit-compatibility.patch
--- nvme-cli-0.8/debian/patches/32-bit-compatibility.patch 1969-12-31 16:00:00.000000000 -0800
+++ nvme-cli-0.8/debian/patches/32-bit-compatibility.patch 2016-07-08 14:34:09.000000000 -0700
@@ -0,0 +1,28 @@
+Author: Steve Langasek <steve.langa...@ubuntu.com>
+Description: Fix compatibility with 32-bit systems
+ nvme-cli is failing to build on 32-bit systems with this error:
+ cc -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -std=gnu99 -O2 -g -Wall -Werror -DLIBUDEV_EXISTS -DNVME_VERSION='"0.8"' -c intel-nvme.c
+ intel-nvme.c: In function ‘get_internal_log’:
+ intel-nvme.c:310:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
+ cmd.addr = (__u64)(void *)buf;
+ ^
+ cc1: all warnings being treated as errors
+ .
+ cmd.addr is defined as __u64 on all architectures, but a pointer is not
+ always 64-bit, making this an error. Cast to 'unsigned long' instead,
+ which is safe on all supported architectures, and let the compiler take it
+ from there.
+
+Index: nvme-cli-0.8/intel-nvme.c
+===================================================================
+--- nvme-cli-0.8.orig/intel-nvme.c
++++ nvme-cli-0.8/intel-nvme.c
+@@ -307,7 +307,7 @@
+ cmd.cdw10 = 0x400;
+ cmd.cdw12 = cfg.log;
+ cmd.data_len = 0x1000;
+- cmd.addr = (__u64)(void *)buf;
++ cmd.addr = (unsigned long)(void *)buf;
+
+ memset(buf, 0, sizeof(buf));
+ err = nvme_submit_passthru(fd, NVME_IOCTL_ADMIN_CMD, &cmd);
diff -Nru nvme-cli-0.8/debian/patches/series nvme-cli-0.8/debian/patches/series
--- nvme-cli-0.8/debian/patches/series 2016-07-03 07:44:08.000000000 -0700
+++ nvme-cli-0.8/debian/patches/series 2016-07-08 14:16:36.000000000 -0700
@@ -1,2 +1,3 @@
0001-Making-cast-explict.patch
0002-Fix-bash-completion-directory.patch
+32-bit-compatibility.patch
--- End Message ---
--- Begin Message ---
Source: nvme-cli
Source-Version: 0.8-2
We believe that the bug you reported is fixed in the latest version of
nvme-cli, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 830...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Breno Leitao <bren...@br.ibm.com> (supplier of updated nvme-cli package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 11 Jul 2016 12:48:11 -0400
Source: nvme-cli
Binary: nvme-cli
Architecture: source
Version: 0.8-2
Distribution: unstable
Urgency: medium
Maintainer: Breno Leitao <bren...@br.ibm.com>
Changed-By: Breno Leitao <bren...@br.ibm.com>
Description:
nvme-cli - userspace tooling to control NVMe drives
Closes: 830521
Changes:
nvme-cli (0.8-2) unstable; urgency=medium
.
* Add a patch to enable nvme-cli to compile on 32 bits system (Thanks Steve
Langasek) (Closes: #830521)
Checksums-Sha1:
26d1de7e758c1efec72d018b39dcde1da0b53753 1696 nvme-cli_0.8-2.dsc
c7cdd4a6598ed0e11560faf5e8300e2ddf1e954d 3828 nvme-cli_0.8-2.debian.tar.xz
Checksums-Sha256:
75af5746a0e193651047abc61c78ca276cc36dc6e904da2e85312da0cba5b4b7 1696
nvme-cli_0.8-2.dsc
236474d3e8e855c9de3c6083ca08146737e490a90b041f0e92dcb25367335962 3828
nvme-cli_0.8-2.debian.tar.xz
Files:
401acc1f8eaae2e8d8215fc6daa469bb 1696 admin optional nvme-cli_0.8-2.dsc
020adb551fd7ff75239f3104d3769aed 3828 admin optional
nvme-cli_0.8-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJXi/o+AAoJEPNPCXROn13Zn4UP/2GdkQczQOzZ3nsComvGdZlD
3CH/Cc3ktdbd2MtKz6fYidhKEtAkbN6/ryMNYXURvdq6D0OyAzgLw6UsTak7YF+D
Ti6QIzaWSGmvD8HqYi2z4HlA+3XlTCSZvvsjmR9oqn2H4Q+GgTaMAlKoi+kZiYPB
lfoVzp4AyQdyqgDMizeWP0/bhqYJW2+A1ZyBrn6KHWBJDYEVLAw+dOxckABzeA0h
Uoe6/637BOP7Jx9Ierp1l+YdwTC5Y69R1O04uZdnBA/gTKMmREg0+rZ4y39qdZGl
oymqcRWngV8OgFWeJuMQijB905OfJF2Lfe/xj+TyKekvS2X05MEqKNP5FlTPfvww
/f48VcOhCLhXELkn3JWMzin1llBav6ADAgdXgFwlLXeIqbTvkeImTvOuhSaCyKBi
M2JB8PQSvlm29x4NDA1D5jcEnYXTGhv+nI5oZhe+u/HuStrhXMBTa1p6SdM6bD5x
92p/F80dD7D8UsNSA/x365YgDhpnNKg/U6Ltglt7FjbytK98wY+Peg1A7V+q9OYj
GUaDvOXIHZnUIw1+xvDf6sf2+Jh6vqfAUoKHv2bm5qfk8C5vrUU3VNJYvOjlSpw6
XcuSQ0tEcJq3UIfgYF7Ie5GmDoqmt71bp0b90xu6uT522rX7V9H2Q4yT+NNAHZm8
QIz0rxtt7oLqM+Git5bk
=/qtg
-----END PGP SIGNATURE-----
--- End Message ---
