Hi Gunnar, to my (limited[1]) knowledge the differences between 5.6 and 7.0 aren't that big from users' perspective, so short patch doesn't have to be wrong for a well-maintained code. See this list of incompatibilites from PHP 7.0 upgrade guide: https://secure.php.net/manual/en/migration70.incompatible.php
The patch is question is a bit confusing, because it obviously mixes fixes for PHP 5.4, PHP 5.5 GD bug and PHP 7.0 updates, but overall it looks good. That said there might be more some changes that wouldn't trigger immediate parse errors, but might change some behavior in more subtle way. However as drupal7 is well-maintained project with good coding standards (am I right?), I would guess the chances are low for this to happen. Anyway I would suggest to update drupal7 with this patch and progress with new updates as we go. You don't have any other options right now anyway, right? :) 1. Fortunately it's been ages since I coded in PHP. Cheers, -- Ondřej Surý <ond...@sury.org> Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server Vše pro chleba (https://vseprochleba.cz) – Potřeby pro pečení chleba všeho druhu On Thu, May 5, 2016, at 21:20, Gunnar Wolf wrote: > tag 821482 + confirmed upstream patch pending > thanks > > Hi, > > I'm contacting pkg-php-maint as recommendad by Ondřej's original mass > bug filing, hopefully avoiding the removal of Drupal7 from Debian. > > As it is now, at version 7.43, Drupal7 is *not* PHP7-clean, and it is > documented with bugs in the upstream tracker: > > https://www.drupal.org/node/2656548 — Drupal 7 PHP 7 testing issue > https://www.drupal.org/node/2454439 — [META] Support PHP 7 > > Following the first link to the bottom, it *seems* that, three days > ago, Mike Carper achieved a clean test run on PHP7: > > https://dispatcher.drupalci.org/job/default/124946/testReport/ > > The patch in question: > > https://www.drupal.org/files/issues/drupal-2656548-21-php7.patch > > Now, the reason to contact pkg-php-maint... Even though I maintain > Drupal7 for a long time, I do consider myself a PHP newbie. Could you > help me ascertain iv the patch makes linguistic sense in PHP7? Help me > check if this looks like enough, and without changing the logic? > > I gave a *very* quick look at it, and the patch looks much shorter > than what I expected. I don't know the extent of the language > incompatibilities between 5.6 and 7, but if this works, I will be a > very happy maintainer. > > I have created a "php7" branch in the packaging repository; I have not > built the package yet, but it should be doable trivially: > > https://anonscm.debian.org/cgit/collab-maint/drupal7.git/commit/?h=php7 > > I intend to do as much testing as I can, but any help is welcome. I am > quite time-stressed, and don't want to delay this until I got time to > dig into it. > > Thanks a lot! > Email had 1 attachment: > + signature.asc > 1k (application/pgp-signature)
