On Thu, 7 Jan 2016 01:28:17 +0100 Jakub Wilk <jw...@debian.org> wrote:
> * Daniel Stender <deb...@danielstender.com>, 2016-01-07, 01:00:
> >+  * Hardcode current LLVM/clang version in debian/ files and in the
> >+    source (added hardcode-llvm-version.patch) to prevent crash of
> >+    afl-clang-fast because default build-time and runtime version
> >+    differs (Closes: #807578).
> 
> I'd expect that afl-clang(-fast) uses clang, not clang-X.Y.
> Also, you patched afl-clang-fast, leaving afl-clang unchanged.
> 
> But this is all unnecessary, because the problem is somewhere else:
> 
> > override_dh_gencontrol:
> >     dh_gencontrol
> >-    debian/dh_clang -p afl-clang
> 
> You were calling dh_clang after dh_gencontrol, which is obviously too late.
> 
> -- 
> Jakub Wilk

I was planning to change hardcode-clang-version.patch to run against and build 
against
clang/llvm 3.7 to get afl for arm64 again (#796343, probably other bugs could 
be resolved by that
move, too), but llvm-3.7 is missing on some other archs currently, so that's 
not an option.

However, I'm going to keep the patch for the next upload although default clang 
doesn't differ
between Unstable and Testing anymore, it could be easily changed when 3.7 gets 
better. Dropping
the patch now and getting it back into charge again later doesn't makes much 
sense.

Anyway, dh_clang has been put into the right place for times hardcoding and 
versioned building
is going to be dropped again. Thanks for the pointer!

DS

-- 
4096R/DF5182C8
46CB 1CA8 9EA3 B743 7676 1DB9 15E0 9AF4 DF51 82C8
LPI certified Linux admin (LPI000329859 64mz6f7kt4)
http://www.danielstender.com/blog/

Reply via email to