Bug#808489: acm: FTBFS: Type of arg 1 to dbmclose must be hash (not constant item) at ./create-tables-5 (perl 5.22?)

[gregor herrmann]

Control: tag -1 + confirmed patch

On Sun, 20 Dec 2015 13:51:08 +0000, Chris West (Faux) wrote:

> perl ./create-tables-5        
> Type of arg 1 to dbmclose must be hash (not constant item) at 
> ./create-tables-5 line 41, near "entities)"
> Type of arg 1 to dbmclose must be hash (not constant item) at 
> ./create-tables-5 line 56, near "sites)"
> Execution of ./create-tables-5 aborted due to compilation errors.

Here's a trivial patch that makes the package build under 5.22 again.


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Flying Pickets

diff -u acm-5.0/debian/changelog acm-5.0/debian/changelog
--- acm-5.0/debian/changelog
+++ acm-5.0/debian/changelog
@@ -1,3 +1,14 @@
+acm (5.0-29.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix "FTBFS: Type of arg 1 to dbmclose must be hash (not constant
+    item) at ./create-tables-5 (perl 5.22?)":
+    Use dbmclose with a hash argument.
+    And close the correct file handles as well.
+    (Closes: #808489)
+
+ -- gregor herrmann <gre...@debian.org>  Sun, 20 Dec 2015 15:21:08 +0100
+
 acm (5.0-29) unstable; urgency=medium
 
   * Fix FTBFS with clang as suggested by Arthur Marble.
only in patch2:
unchanged:
--- acm-5.0.orig/dis/data/create-tables-4
+++ acm-5.0/dis/data/create-tables-4
@@ -36,7 +36,7 @@
 	@last_a = @a;
 
 }
-dbmclose (entities);
+dbmclose (%entities);
 close (ENTITIES);
 
 open (SITES, "./sites");
@@ -51,6 +51,6 @@
 	$sites{$key} = $a[1];
     }
 }
-dbmclose (sites);
-close (ENTITIES);
+dbmclose (%sites);
+close (SITES);
 
only in patch2:
unchanged:
--- acm-5.0.orig/dis/data/create-tables-5
+++ acm-5.0/dis/data/create-tables-5
@@ -38,7 +38,7 @@
 	@last_a = @a;
 
 }
-dbmclose (entities);
+dbmclose (%entities);
 close (ENTITIES);
 
 open (SITES, "./sites");
@@ -53,6 +53,6 @@
 	$sites{$key} = $a[1];
     }
 }
-dbmclose (sites);
-close (ENTITIES);
+dbmclose (%sites);
+close (SITES);
 
only in patch2:
unchanged:
--- acm-5.0.orig/dis/data/test-entities
+++ acm-5.0/dis/data/test-entities
@@ -13,4 +13,4 @@
 $key = pack ("CCSCCCC",
 	$a[0], $a[1], $a[2], $a[3], $a[4], $a[5], $a[6]);
 print "We should find an F-16C: \"", $entities{$key}, "\"\n";
-dbmclose (entities);
+dbmclose (%entities);

signature.asc
Description: Digital Signature