Control: tags -1 patch Hi Chris,
On 06.11.2015 12:37, Chris Lamb wrote: > harvid fails to build from source in unstable/amd64: > > [..] > > cc -c -o timecode.o -g -O2 -fstack-protector-strong -Wformat > -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 `pkg-config > --cflags libavcodec libavformat libavutil libswscale` timecode.c > export PKG_CONFIG_PATH=;\ > cc -c -o vinfo.o -g -O2 -fstack-protector-strong -Wformat > -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 `pkg-config > --cflags libavcodec libavformat libavutil libswscale` vinfo.c > make[3]: *** No rule to make target '../libharvid/libharvid.a', needed > by 'harvid'. Stop. The problem is that upstream's Makefile is not compatible with parallel building. Attached patch fixes this. Best regards, Andreas
Description: Fix parallel build libharvid is required to build the harvid binary in the src directory. Declaring this dependency is only possible, when changing the $(SUBDIRS) target from double-colon to single-colon, since double-colon implies independence. But then it has to be marked .PHONY as well, or nothing will be built. Author: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> Last-Update: <2015-11-06> --- harvid-0.8.0.orig/Makefile +++ harvid-0.8.0/Makefile @@ -3,7 +3,9 @@ SUBDIRS = libharvid src doc default: all -$(SUBDIRS):: +src: libharvid + +$(SUBDIRS): $(MAKE) -C $@ $(MAKECMDGOALS) all clean man install uninstall install-bin install-man uninstall-bin uninstall-man install-lib uninstall-lib: $(SUBDIRS) @@ -11,4 +13,4 @@ all clean man install uninstall install-bin install-man uninstall-bin uninstall- dist: git archive --format=tar --prefix=harvid-$(VERSION)/ HEAD | gzip -9 > harvid-$(VERSION).tar.gz -.PHONY: clean all subdirs install uninstall dist install-bin install-man uninstall-bin uninstall-man install-lib uninstall-lib +.PHONY: clean all subdirs install uninstall dist install-bin install-man uninstall-bin uninstall-man install-lib uninstall-lib $(SUBDIRS)
