Package: mysql-workbench
Version:  6.3.4+dfsg-2
Severity: serious

When building mysql-workbench on arm*, ppc* and s390x there are errors like.

/«BUILDDIR»/mysql-workbench-6.3.4+dfsg/library/sql.parser/source/ctype-utf8.cpp:
 In function 'int mysql_parser::hexlo(int)':
/«BUILDDIR»/mysql-workbench-6.3.4+dfsg/library/sql.parser/source/ctype-utf8.cpp:3890:3:
 error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]
   };
   ^
/«BUILDDIR»/mysql-workbench-6.3.4+dfsg/library/sql.parser/source/ctype-utf8.cpp:3890:3:
 error: narrowing conversion of '-1' from 'int' to 'char' inside { } 
[-Wnarrowing]


then the error repeats a load of times (with the same sourcecode position given each time).

The signdness of plain char is implementation dependent. On linux systems it depends on the CPU architecture.

Investigating the sourcecode shows an array of char with many values initialised to -1. To fix this I changed data type to signed char

I have successfully built the package with this change in a raspbian stretch-staging environment and uploaded to raspbian. I have not tested it beyond that. A debdiff can be found at http://debdiffs.raspbian.org/main/m/mysql-workbench/mysql-workbench_6.3.4+dfsg-2+rpi1.debdiff No intent to NMU in Debian.

Reply via email to