Hi Paul,

>> Looks like the JQuery DataTables libraries included are flagged as minified
>> without source on the basis that they have lines longer than 1024 characters:
>> P: aegean source: source-contains-prebuilt-javascript-object 
>> data/share/vendor/jquery.dataTables.js line length is 1397 characters (>1024)
>> E: aegean source: source-is-missing data/share/vendor/jquery.dataTables.js
>> [...]
> 
> lintian is absolutely correct to flag this file, it is generated from a
> bunch of other JavaScript files using Bash, PHP 5.4+, JSHint 2.1+ and
> the Closure compiler, at least according to the upstream git repos:
> 
> https://github.com/DataTables/DataTablesSrc/
> https://github.com/DataTables/DataTables/

Wow, I see (and can’t help but feel a slight WTF about this building setup). 
Thanks for pointing this out. I guess the cleanest way to proceed here would be 
to properly package DataTables built from source as a dependency for aegean. 
Then it wouldn't need to be included with the aegean source anymore, as it is 
already the case with its other JS dependencies. I’ll put this on my agenda.

> I'm not sure what the correct heuristics to use are but in the
> jquery.dataTables.js case the existing ones produced the right result.

OK. Still, I feel that line length probably is a bit weak as evidence.

Cheers,
Sascha

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

Reply via email to