On Mon, 21 Sep 201509:27:23 -0400 Scott Kitterman <deb...@kitterman.com> wrote:
> To start with, pitivi only builds against a single python3 version (the > default), not all versions, so it should build-dep on python3-dev vice > python3-all-dev. The python3-all-dev build-dep makes it appear on the list > of candidate packages for the python3.5 transition [1], which is should not. Thanks, will fix with next upload > That is, however, probably the most minor thing I noticed once I started > looking. > > In the depends, it should be python3:Depends vice python:Depends. Since the > python files are shipped in a private library location, you will have to > specify the location to dh_python3 (see man dh_python3, private dirs. > > The generated python3 depends should currently look like: > > python3 (<< 3.5), python3 (>= 3.4~) > > The manual python3 depends should be removed. I was not able to figure out > how to make this work, but I suspect it has to do with a linking issue in the > build. Ack > If you look at the i386 build log [2], it contains: > > dpkg-shlibdeps: warning: > debian/pitivi/usr/lib/i386-linux-gnu/pitivi/python/pitivi/timeline/renderer.so > contains an unresolvable reference to symbol PyList_GetItem: it's probably a > plugin > dpkg-shlibdeps: warning: 8 other similar warnings have been skipped (use -v > to see them all) > > PyList_GetItem is provided by python3.4, so this is not a plugin, it's a > missing link. My understanding is that you don't link Python modules against libpython, because the interpreter is already statically linked against libpython itself. > I suspect that between fixing that and the private dirs issue for dh_python3, > the depends issue should end up sorted. > > Finally, if you look at the file list for the binary (the same i386 build log > [2] provides a convenient place to look), there are multiple __pycache__ > directories in the binary that should not be there. Those should be generated > on the target system. Thanks!
signature.asc
Description: This is a digitally signed message part
