Control: tags -1 patch

On Fri, 2015-08-14 at 08:24 +0200, Fabian Greffrath wrote:
> Am Donnerstag, den 13.08.2015, 23:05 +0200 schrieb Evgeni Golov:
> > But both, my local build and the one on asachi contain -lSDL.
> 
> Strange! I can reproduce the bug, gnujump fails to compile on my
> system.

Hi,

This was intriguing me so I had a bit of a look at it :)

In acinclude.m4 there is a typo on line 276 which caused the
AX_CHECK_GLU function not to be defined correctly. Ordinarily this
isn't much of a problem since GLU isn't actually used by gnujump.

However, autoconf-archive also has a (different) implementation of
AX_CHECK_GLU which gets used instead if the package is installed. This
version has a bug in it which trashes the LIBS variable (#795479) where
-lSDL had already been specified.

I couldn't reproduce this when using sbuild (and I suspect it will
never occur on a buildd) since autoconf-archive isn't installed there.

Doing any one of the following should fix this:
1) Fix the typo in acinclude.m4 so gnujump's implementation is used.
2) Completely remove the call to AX_CHECK_GLU in configure.in.
3) Build-Conflict on autoconf-archive.
4) Wait for #795479 (the autoconf-archive bug) to be fixed.

I've attached a patch for the first solution since it seems the easiest
to me.

Thanks,
James
diff -u -r a/acinclude.m4 b/acinclude.m4
--- a/acinclude.m4	2008-08-11 14:04:47.000000000 +0100
+++ b/acinclude.m4	2015-08-14 12:22:49.825670506 +0100
@@ -273,7 +273,7 @@
 AC_SUBST([GL_LIBS])
 ])dnl
 
-C_DEFUN([AX_CHECK_GLU],
+AC_DEFUN([AX_CHECK_GLU],
 [AC_REQUIRE([AX_CHECK_GL])dnl
 AC_REQUIRE([AC_PROG_CXX])dnl
 GLU_CFLAGS="${GL_CFLAGS}"

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to