On Thu, 09 Jul 2015 12:47:21 -0600, Linn Crosetto wrote:

> Here is a patch to mark the non-standard function identifier __FUNCTION__
> with the __extension__ keyword to work around the build failure with GCC-5.

Thanks for this patch.

Unfortunately there seems to be a problem. After applying it the
build (with gcc 5 from experimental) fails with:

 debian/rules build
dh_testdir
/usr/bin/make
make[1]: Entering directory '/tmp/buildd/libpam-chroot-0.9'
gcc -fPIC -O2 -Wall -Werror -pedantic -I.  -c -o pam_chroot.o pam_chroot.c
pam_chroot.c: In function '_pam_opts_init':
pam_chroot.c:71:45: error: ISO C does not support '__FUNCTION__' predefined 
identifier [-Werror=pedantic]
   _pam_log(LOG_ERR, "%s: NULL opts pointer", __FUNCTION__);
                                             ^
pam_chroot.c: In function '_pam_opts_config':
pam_chroot.c:94:45: error: ISO C does not support '__FUNCTION__' predefined 
identifier [-Werror=pedantic]
   _pam_log(LOG_ERR, "%s: NULL opts pointer", __FUNCTION__);
                                             ^
pam_chroot.c: In function '_pam_opts_free':
pam_chroot.c:165:45: error: ISO C does not support '__FUNCTION__' predefined 
identifier [-Werror=pedantic]
   _pam_log(LOG_ERR, "%s: NULL opts pointer", __FUNCTION__);
                                             ^
pam_chroot.c: In function '_pam_get_groups':
pam_chroot.c:264:19: error: ISO C does not support '__FUNCTION__' predefined 
identifier [-Werror=pedantic]
     opts->module, __FUNCTION__, strerror(errno));
                   ^
pam_chroot.c:271:19: error: ISO C does not support '__FUNCTION__' predefined 
identifier [-Werror=pedantic]
     opts->module, __FUNCTION__);
                   ^
pam_chroot.c:276:19: error: ISO C does not support '__FUNCTION__' predefined 
identifier [-Werror=pedantic]
     opts->module, __FUNCTION__, user);
                   ^
pam_chroot.c:285:19: error: ISO C does not support '__FUNCTION__' predefined 
identifier [-Werror=pedantic]
     opts->module, __FUNCTION__, strerror(errno));
                   ^
pam_chroot.c: In function '_pam_get_chrootdir':
pam_chroot.c:536:22: error: ISO C does not support '__FUNCTION__' predefined 
identifier [-Werror=pedantic]
        opts->module, __FUNCTION__, strerror(errno));
                      ^
cc1: all warnings being treated as errors
<builtin>: recipe for target 'pam_chroot.o' failed
make[1]: *** [pam_chroot.o] Error 1
make[1]: Leaving directory '/tmp/buildd/libpam-chroot-0.9'
debian/rules:16: recipe for target 'build-stamp' failed


The build ins unstable with gcc 4.9 succeeds.

Maybe removing -pedantic from Makefile would be a way forward?


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Treibhaus: Sergent Garcia

Attachment: signature.asc
Description: Digital Signature

Reply via email to