Control: tag -1 + patch
Hi,
Daniel Schepler wrote:
> debian/rules override_dh_auto_build
> make[1]: Entering directory '/tmp/buildd/tty-clock-2.0'
> /usr/bin/make CFLAGS="-g -O2 -fstack-protector-strong -Wformat
> -Werror=format-security -D_FORTIFY_SOURCE=2"
> make[2]: Entering directory '/tmp/buildd/tty-clock-2.0'
> build ttyclock.c
> CC -g -O2 -fstack-protector-strong -Wformat -Werror=format-security
> -D_FORTIFY_SOURCE=2 -L -lncurses -ltinfo -Wl,-z,relro ttyclock.c
^^
> /tmp/ccXUQlb9.o: In function `cleanup':
> /tmp/buildd/tty-clock-2.0/ttyclock.c:154: undefined reference to `delscreen'
> /tmp/ccXUQlb9.o: In function `draw_number':
> /tmp/buildd/tty-clock-2.0/ttyclock.c:218: undefined reference to `wbkgdset'
> /tmp/buildd/tty-clock-2.0/ttyclock.c:219: undefined reference to `wmove'
> /tmp/buildd/tty-clock-2.0/ttyclock.c:219: undefined reference to `waddch'
Reason for this is that the parameter to "-L" is missing and hence
"-lncurses" is parsed as parameter to "-L", i.e. ignored.
This comes from this line in the upstream Makefile:
LDFLAGS := -L $$(ncurses5-config --libdir) $$(ncurses5-config --libs) ${LDFLAGS}
And "ncurses5-config --libdir" indeed outputs nothing. (No idea why.)
The following debdiff fixes this issue:
diff -Nru tty-clock-2.0/debian/changelog tty-clock-2.0/debian/changelog
--- tty-clock-2.0/debian/changelog 2013-05-05 23:26:16.000000000 +0200
+++ tty-clock-2.0/debian/changelog 2015-07-15 16:44:05.000000000 +0200
@@ -1,3 +1,10 @@
+tty-clock (2.0-2.1) unstable; urgency=low
+
+ * Fix FTBFS by updating the patch to quote the compiler's -L parameter
+ in the upstream Makefile which can be empty. (Closes: #788749)
+
+ -- Axel Beckert <a...@debian.org> Wed, 15 Jul 2015 16:43:18 +0200
+
tty-clock (2.0-2) unstable; urgency=low
* upload to unstable
diff -Nru tty-clock-2.0/debian/patches/debian-changes
tty-clock-2.0/debian/patches/debian-changes
--- tty-clock-2.0/debian/patches/debian-changes 2013-05-05 23:28:21.000000000
+0200
+++ tty-clock-2.0/debian/patches/debian-changes 2015-07-15 16:57:27.000000000
+0200
@@ -32,7 +32,7 @@
-CFLAGS = -Wall -g -I $$(ncurses5-config --includedir)
-LDFLAGS = -L $$(ncurses5-config --libdir) $$(ncurses5-config --libs)
+CFLAGS := -Wall -g -I $$(ncurses5-config --includedir) ${CFLAGS}
-+LDFLAGS := -L $$(ncurses5-config --libdir) $$(ncurses5-config --libs)
${LDFLAGS}
++LDFLAGS := -L '$$(ncurses5-config --libdir)' $$(ncurses5-config --libs)
${LDFLAGS}
tty-clock : ${SRC}
Antoine: Do you want me to NMU this? I see there is already a 2.1
package in your git repository which seem to fix this, too, just differently:
https://redmine.koumbit.net/projects/tty-clock/repository/revisions/debian/entry/debian/changelog
But I don't see any upload of it so far:
https://packages.qa.debian.org/t/tty-clock.html
Regards, Axel
--
,''`. | Axel Beckert <a...@debian.org>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
