control: tag -1 confirmed, help

On Wed, May 27, 2015 at 7:25 AM, Yves-Alexis Perez wrote:
> Note that the binary blob is executed throught native client, which is
> not enabled by default, so I /think/ you need explicit action from the
> user (although if you enable NaCl for something else, then you might
> enable stuff you actually don't want).

I made a quick attempt at getting hotword disabled, but wasn't effective.

I won't have time to dig into the details for a while, so I'm
attaching the failed attempt to maybe inspire some other ideas.

Best wishes,
Mike
--- a/chrome/browser/extensions/api/hotword_private/hotword_private_api.cc
+++ b/chrome/browser/extensions/api/hotword_private/hotword_private_api.cc
@@ -121,7 +121,7 @@ bool HotwordPrivateSetEnabledFunction::R
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   PrefService* prefs = GetProfile()->GetPrefs();
-  prefs->SetBoolean(prefs::kHotwordSearchEnabled, params->state);
+  prefs->SetBoolean(prefs::kHotwordSearchEnabled, false);
   return true;
 }
 
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -244,9 +244,6 @@ cr.define('options', function() {
       HotwordSearchSettingIndicator.decorate(hotwordIndicator);
       hotwordIndicator.disabledOnErrorSection =
           $('hotword-always-on-search-checkbox');
-      chrome.send('requestHotwordAvailable');
-
-      chrome.send('requestGoogleNowAvailable');
 
       if ($('set-wallpaper')) {
         $('set-wallpaper').onclick = function(event) {

Reply via email to