Source: libwebp
Version: 0.4.3-1
Severity: serious
Tags: patch

Hi,

libwebp FTBFS on mips with this error (initially):

> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../src/webp 
> -D_FORTIFY_SOURCE=2 -Wall -Wdeclaration-after-statement -Wextra 
> -Wmissing-declarations -Wmissing-prototypes -Wold-style-definition -Wshadow 
> -Wunused-but-set-variable -Wunused -Wvla -g -O2 -fstack-protector-strong 
> -Wformat -Werror=format-security -pthread -c lossless_mips32.c  -fPIC -DPIC 
> -o .libs/libwebpdsp_la-lossless_mips32.o
> /tmp/cc07vjZt.s: Assembler messages:
> /tmp/cc07vjZt.s:52: Error: opcode not supported on this processor: mips2 
> (mips2) `madd $6,$5'
> /tmp/cc07vjZt.s:53: Error: opcode not supported on this processor: mips2 
> (mips2) `madd $6,$4'
> /tmp/cc07vjZt.s:140: Error: opcode not supported on this processor: mips2 
> (mips2) `madd $9,$3'
> /tmp/cc07vjZt.s:141: Error: opcode not supported on this processor: mips2 
> (mips2) `madd $9,$7'
> /tmp/cc07vjZt.s:1328: Error: opcode not supported on this processor: mips2 
> (mips2) `clz $6,$4'
> /tmp/cc07vjZt.s:1545: Error: opcode not supported on this processor: mips2 
> (mips2) `clz $6,$4'
> make[3]: *** [libwebpdsp_la-lossless_mips32.lo] Error 1

There was a patch 'fix-mips2.patch' to fix this but it was dropped in
the 0.4.3-1 upload.

I've attached an updated patch which fixes this.

Thanks,
James
--- a/src/dsp/dsp.h
+++ b/src/dsp/dsp.h
@@ -73,7 +73,7 @@ extern "C" {
 #define WEBP_USE_NEON
 #endif
 
-#if defined(__mips__) && !defined(__mips64) && (__mips_isa_rev < 6)
+#if defined(__mips__) && !defined(__mips64) && (__mips_isa_rev >= 1) && (__mips_isa_rev < 6)
 #define WEBP_USE_MIPS32
 #if (__mips_isa_rev >= 2)
 #define WEBP_USE_MIPS32_R2

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to