On Wed, Mar 18, 2015 at 12:41:56AM +0100, Andreas Beckmann wrote:
> On 2015-03-17 11:21, Mark Brown wrote:

> > OK, thanks for the command lines.  How about the analysis for the patch?
> > I'm not keen on just applying random changes without understanding.

Actually having opened the logs I'm not seeing the command lines, the
logs appear to start with displaying output from the commend.

> As I understood #735268, the strict dependency xemacs21-support ->
> xemacs21 is no longer needed, so I removed that as well to break the
> circular dependency and always have a deterministic configuration order
> of the xemacs21 packages - that would simplify further debugging (which
> luckily was not needed). All xemacs21* packages passed my piuparts tests
> after applying this patch - no more hangs :-)

So you made this additional change in the hope that it might be
useful rather than as a targetted part of the same fix?  It is bad
practice to mix unrelated changes into a single patch since it makes
things harder to follow, means that review issues from unrelated changes
can mean that good parts of the change can't be applied or directed
appropriately.

Attachment: signature.asc
Description: Digital signature

Reply via email to