[adding the bug to CC] Am 20.03.2015 um 08:46 schrieb Didier Roche: > Le 20/03/2015 08:39, Michael Biebl a écrit :
>> thanks for the patch. I had something like this in mind. >> We could be extra nice and only add the After=tmp.mount if tmp.mount is >> actually enabled, because we only need the After ordering in this case. >> But that's mostly a cosmetic issue and I'm happy to ship the patch as is. > > That's a nice idea. It needs testing though to ensure that the fstab > generator generated the right enablement for that unit (in case the > tmpfs config was done in fstab). /etc/fstab entries are automatically hooked up in /run/systemd/generator/local-fs.target.requires/ unless the fstab entry uses noauto. That said, I'm not sure if we should really test the file system path. We should check if systemd offers an API for this. Also, we need to ensure that any later > enablement of that unit, this is taken into account by new units. Not > sure I'll have time to test this properly today, will be more early next > week if needed though. As said, I'd probably be happy to ship the patch as is and would include it in the upload I plan this weekend. We can defer this to a later upload though, if you want? -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
