Your message dated Tue, 24 Feb 2015 11:33:50 +0000
with message-id <e1yqdkm-0007oy...@franck.debian.org>
and subject line Bug#717190: fixed in hdparm 9.43-2
has caused the Debian Bug report #717190,
regarding Leaves RAID sync speed set to 0
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
717190: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=717190
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: hdparm
Version: 9.39-1+b1
Severity: grave
File: /lib/udev/rules.d/85-hdparm.rules
X-Debbugs-CC: anth...@derobert.net

I enabled RAID_WORKAROUND, and it managed to leave sync_speed_min and
sync_speed_max set to 0. That of course had a degraded RAID array sitting
there, not rebuilding—a scenario that puts data at great risk.

Looking at the scripts, I think what happens is that 85-hdparm.rules calls the
init script, which does:

1. save current value of sync speeds to variables
2. change both to 0.
3. call hdparm
4. restore from variables.

but udev works in parallel, so multiple "hotplugs" can happen at once. Leading 
to
a race:

a1. save (200k)
a2. change (from 200k to 0)
b1. save (this will save 0!)
a3. hdparm
b2. change (from 0 to 0)
b3. hdparm
a4. restore (back to 200k)
b4. restore (back to 0) (!)

Of course, that race can go other ways, such as calling hdparm with the rebuild
in progress (which supposedly corrupts data). Or both could happen.

The most obvious approach to fix this is locking.

There are related bugs, such as each RAID array actually can use a non-default
set of sync speed parameters, set in /sys. But I think that can be documented
and left to the user to solve.

-- System Information:
Debian Release: 7.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages hdparm depends on:
ii  libc6     2.13-38
ii  lsb-base  4.1+Debian8+deb7u1

Versions of packages hdparm recommends:
ii  powermgmt-base  1.31

Versions of packages hdparm suggests:
pn  apmd  <none>

-- Configuration Files:
/etc/default/hdparm changed:
harddisks=/dev/sd[a-f]
hdparm_opts="-B 255"
RAID_WORKAROUND=yes


-- no debconf information

--- End Message ---
--- Begin Message ---
Source: hdparm
Source-Version: 9.43-2

We believe that the bug you reported is fixed in the latest version of
hdparm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 717...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Meskes <mes...@debian.org> (supplier of updated hdparm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 24 Feb 2015 11:59:58 +0100
Source: hdparm
Binary: hdparm hdparm-dbg hdparm-udeb
Architecture: source amd64
Version: 9.43-2
Distribution: unstable
Urgency: medium
Maintainer: Stephen Gran <sg...@debian.org>
Changed-By: Michael Meskes <mes...@debian.org>
Description:
 hdparm     - tune hard disk parameters for high performance
 hdparm-dbg - debug files for hdparm
 hdparm-udeb - tune hard disk parameters for high performance (udeb)
Closes: 717190 725284
Changes:
 hdparm (9.43-2) unstable; urgency=medium
 .
   * Synced from Ubuntu: (Closes: #725284)
     - reset apm options between devices
     - add script that gets run from udev when a new device is added
   * Added locking to prevent race in RAID setup.
     Thanks to Simon Elsbrock <si...@iodev.org> (Closes: #717190)
Checksums-Sha1:
 b4f4a492662befd7b2aafd99a4d02ee4c78cc254 1847 hdparm_9.43-2.dsc
 503849a7190d0b9fd2e24c8ea8db636e7a1a9693 15111 hdparm_9.43-2.diff.gz
 420da74e62978820320456e7aaaa215f69914394 106142 hdparm_9.43-2_amd64.deb
 7b6060de3a4687fc38c15e4bf49840690b80ca1c 83318 hdparm-dbg_9.43-2_amd64.deb
 f6ce444b8eec20f2f66e7be3d054604ba8bae6f6 44046 hdparm-udeb_9.43-2_amd64.udeb
Checksums-Sha256:
 a812d37fdec9c1f0340a6485662628f97fa8d370b94842fe585f1170b257426e 1847 
hdparm_9.43-2.dsc
 c97f106f24874f62fdc9f22552b87543ec36484505661764ef3ef4f44bed6b42 15111 
hdparm_9.43-2.diff.gz
 a9260ee439cca81b56f908f03f4d18514a6287b8852589db247809067dc00d67 106142 
hdparm_9.43-2_amd64.deb
 df864d694e179fd8647679866d2c8ce81b5570e57ca9421065f7421d4b70caf5 83318 
hdparm-dbg_9.43-2_amd64.deb
 04e6696dc82e1012e57f0c173bf57cf31eda1714274900b7f55d5ab2dbc454c1 44046 
hdparm-udeb_9.43-2_amd64.udeb
Files:
 0383edb355ce9f35212acb3e09b00041 1847 admin optional hdparm_9.43-2.dsc
 ac774235192c01a1a062d6c3a39a73bf 15111 admin optional hdparm_9.43-2.diff.gz
 35cdc76b1168715b738af9c8439ad277 106142 admin optional hdparm_9.43-2_amd64.deb
 88167e3f3fcf189acfa6e7e8bcb66c5e 83318 debug extra hdparm-dbg_9.43-2_amd64.deb
 2b3a16ad400539ce0c20a6f29f4df30f 44046 debian-installer optional 
hdparm-udeb_9.43-2_amd64.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIVAwUBVOxb3TXYV8C7yzslAQikmA/9H/66lxbg852EABrpceabCrhpG9voi1wm
r+zvsnZDK3Jx/fWTXB3xzGAA4iGhG64dYzYdIvauHfPJnpdt/nTNHmhd50t2G18Q
jkq/MDWDq93xMQjus9oTkEPKyiSynXHrvwJr0pObVxE2RhPTGrorIvFc+ArOIBx3
Jiuf1eoAbMpMRcjFtn+Cr3DOFOdB/amdvIvzlTaqhUfpb6YXbKdT2hbQED4b0eMB
tvdYoZlUqa749GhbSaJ08RnMy81eKQgQt3Fjr3MjTTIaTrGZFKjou3qa8hEsJlbr
veWJjCTMRJXSgLgNGmEKS1sOUFeLtg3h61SIpjqXerUufTGaApkvexz4m3QK6GSq
+sDU87krmHR/lgqBSKOe/Bb+ndz2ydN5VOrwB+hqAvR7OKJ1COC8NzLxrXfiCOc8
yjflAutISE+k8hu3+ZDjm9ziZVlhhSXDHVIL5xFxYVkzZyu+ZiP5a7Nfk9eIM2QY
o9iAGMxqx//XYvOwLgeYyo/869l5FSAPy91SKmPA2nD3oLJB+nR1yLz4coizM6B9
cIROCIs7fGQqnaamwGsvHC8fMOHnKpcWU7yyFATBZ4fv+k4lUDeMnK/Gh3hs43lJ
yxoRGMFfUeTGKyHpfagV0ZckGZfJSdz5AE+WdLd8x0j5ZMnlq/PCNbipJfGfoKaI
HqzAsqGem3A=
=vppd
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to