On 15/02/15 23:55, Tomasz Buchert wrote:
>
> [...]
(@Julian: sorry for not CCing you before)
Hi again,
I couldn't fall asleep, so there you go:
The tricky HTTPS server returns this line: "HTTP/1.1 302". Note that
there is no "explanation" for the status code 302 (it should be
"Found"). Anyway, this is fine, the code seems to be prepared for
that case: elements is set to 3 in server.cc:128.
However, Owner is NULL (I don't know why, I don't know the code, but
it is) so Owner->Debug fails in server.cc:132.
The attached patch checks whether Owner is NULL before dereferencing
it. This fixes this problem for me, but somebody who knows what Owner
is should make sure that it makes sense. Feel free to adjust the
patch to your needs, it's in public domain.
Cheers,
Tomasz
>From 3afccaefccc9045d5d1236f09d4cc90cc721c8ef Mon Sep 17 00:00:00 2001
From: Tomasz Buchert <tomasz.buch...@inria.fr>
Date: Mon, 16 Feb 2015 00:57:29 +0100
Subject: [PATCH] simple fix
---
methods/server.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/methods/server.cc b/methods/server.cc
index cb0341d..e321e02 100644
--- a/methods/server.cc
+++ b/methods/server.cc
@@ -129,7 +129,7 @@ bool ServerState::HeaderLine(string Line)
if (elements == 3)
{
Code[0] = '\0';
- if (Owner->Debug == true)
+ if (Owner != NULL && Owner->Debug == true)
clog << "HTTP server doesn't give Reason-Phrase for " << Result << std::endl;
}
else if (elements != 4)
--
2.1.4
