Your message dated Sun, 15 Feb 2015 21:34:11 +0000
with message-id <e1yn6pp-0005rk...@franck.debian.org>
and subject line Bug#777024: fixed in gst-plugins-bad1.0 1.4.4-2.1
has caused the Debian Bug report #777024,
regarding gmediarender segfaults on startup on armel, raspbian and possiblly 
other architectures if gstreamer1.0-plugins-bad is installed.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
777024: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=777024
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
package: gstreamer1.0-plugins-bad
version: 1.4.3-2
severity: grave
tags: patch

We received a report in raspbian, that gmediarender was segfaulting on startup. Further investigation by the original reporter showed that it only happened if gstreamer1.0-plugins-bad was installed.

https://bugs.launchpad.net/raspbian/+bug/1392850

The reporter took it to upstream who tracked the problem down to an incorrect call to a variadic function.

https://bugzilla.gnome.org/show_bug.cgi?id=740191
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=3e1d7630187dd96b137553aec2c6edb60c213682

AIUI this has the potential to crash on most 32-bit architectures (on 64-bit architectures I belive alignment requirements will mask the problem), whether it actually crashes depends on what happens to be on the stack/in the registers at the time.

My tests have shown that this does not appear to crash on debian armhf at the moment but it does appear to crash on debian armel.

While working on this issue I also ran into an "unrepresentable changes to source" error caused by incomplete cleanup in your clean target. So I fixed that too.

Debdiff attatched, no intent to nmu

P.S. theres some noise in the debdiff, looks like your clean target needs further work.
diff -Nru gst-plugins-bad1.0-1.4.4/debian/changelog 
gst-plugins-bad1.0-1.4.4/debian/changelog
--- gst-plugins-bad1.0-1.4.4/debian/changelog   2014-11-11 12:40:17.000000000 
+0000
+++ gst-plugins-bad1.0-1.4.4/debian/changelog   2015-02-03 22:25:43.000000000 
+0000
@@ -1,3 +1,18 @@
+gst-plugins-bad1.0 (1.4.4-2+rpi2) jessie-staging; urgency=medium
+
+  * Really apply the patch to fix gmediarender segfault.
+  * Remove win32/common/config.h-new in clean target to prevent
+    "unrepresentable changes to source" error when building a second time.
+
+ -- Peter Michael Green <plugw...@raspbian.org>  Tue, 03 Feb 2015 22:10:57 
+0000
+
+gst-plugins-bad1.0 (1.4.4-2+rpi1) jessie-staging; urgency=medium
+
+  * Apply upstream patch to fix gmediarendered segfault on startup
+    (LP: 1392850)
+
+ -- Peter Michael Green <plugw...@raspbian.org>  Fri, 26 Dec 2014 14:24:44 
+0000
+
 gst-plugins-bad1.0 (1.4.4-2) unstable; urgency=medium
 
   * Upload to unstable.
diff -Nru gst-plugins-bad1.0-1.4.4/debian/libgstreamer-plugins-bad1.0-0.install 
gst-plugins-bad1.0-1.4.4/debian/libgstreamer-plugins-bad1.0-0.install
--- gst-plugins-bad1.0-1.4.4/debian/libgstreamer-plugins-bad1.0-0.install       
1970-01-01 00:00:00.000000000 +0000
+++ gst-plugins-bad1.0-1.4.4/debian/libgstreamer-plugins-bad1.0-0.install       
2014-12-26 15:22:08.000000000 +0000
@@ -0,0 +1,10 @@
+debian/tmp/usr/lib/*/libgstphotography-1.0.so.*
+debian/tmp/usr/lib/*/libgstbadbase-1.0.so.*
+debian/tmp/usr/lib/*/libgstbadvideo-1.0.so.*
+debian/tmp/usr/lib/*/libgstbasecamerabinsrc-1.0.so.*
+debian/tmp/usr/lib/*/libgstgl-1.0.so.*
+debian/tmp/usr/lib/*/libgstinsertbin-1.0.so.*
+debian/tmp/usr/lib/*/libgstcodecparsers-1.0.so.*
+debian/tmp/usr/lib/*/libgstmpegts-1.0.so.*
+debian/tmp/usr/lib/*/libgsturidownloader-1.0.so.*
+debian/tmp/usr/lib/arm-linux-gnueabihf/libgstwayland-1.0.so.*
diff -Nru 
gst-plugins-bad1.0-1.4.4/debian/libgstreamer-plugins-bad1.0-dev.install 
gst-plugins-bad1.0-1.4.4/debian/libgstreamer-plugins-bad1.0-dev.install
--- gst-plugins-bad1.0-1.4.4/debian/libgstreamer-plugins-bad1.0-dev.install     
1970-01-01 00:00:00.000000000 +0000
+++ gst-plugins-bad1.0-1.4.4/debian/libgstreamer-plugins-bad1.0-dev.install     
2014-12-26 15:22:08.000000000 +0000
@@ -0,0 +1,3 @@
+debian/tmp/usr/include
+debian/tmp/usr/lib/*/pkgconfig
+debian/tmp/usr/lib/*/*.so
diff -Nru gst-plugins-bad1.0-1.4.4/debian/patches/fix-segfault-varargs.patch 
gst-plugins-bad1.0-1.4.4/debian/patches/fix-segfault-varargs.patch
--- gst-plugins-bad1.0-1.4.4/debian/patches/fix-segfault-varargs.patch  
1970-01-01 00:00:00.000000000 +0000
+++ gst-plugins-bad1.0-1.4.4/debian/patches/fix-segfault-varargs.patch  
2015-02-03 22:12:57.000000000 +0000
@@ -0,0 +1,21 @@
+commit 3e1d7630187dd96b137553aec2c6edb60c213682
+Author: Tim-Philipp Müller <t...@centricular.com>
+Date:   Sat Nov 15 21:59:48 2014 +0000
+
+    dvbbasebin: fix possible crash by passing 64 bits for 64-bit queue property
+    
+    https://bugzilla.gnome.org/show_bug.cgi?id=740191
+
+Index: gst-plugins-bad1.0-1.4.4/sys/dvb/dvbbasebin.c
+===================================================================
+--- gst-plugins-bad1.0-1.4.4.orig/sys/dvb/dvbbasebin.c
++++ gst-plugins-bad1.0-1.4.4/sys/dvb/dvbbasebin.c
+@@ -417,7 +417,7 @@ dvb_base_bin_init (DvbBaseBin * dvbbaseb
+   dvbbasebin->tsparse = gst_element_factory_make ("tsparse", NULL);
+ 
+   g_object_set (dvbbasebin->buffer_queue, "max-size-buffers", 0,
+-      "max-size-bytes", 0, "max-size-time", 0, NULL);
++      "max-size-bytes", 0, "max-size-time", (guint64) 0, NULL);
+ 
+   gst_bin_add_many (GST_BIN (dvbbasebin), dvbbasebin->dvbsrc,
+       dvbbasebin->buffer_queue, dvbbasebin->tsparse, NULL);
diff -Nru gst-plugins-bad1.0-1.4.4/debian/patches/series 
gst-plugins-bad1.0-1.4.4/debian/patches/series
--- gst-plugins-bad1.0-1.4.4/debian/patches/series      2014-11-06 
11:48:06.000000000 +0000
+++ gst-plugins-bad1.0-1.4.4/debian/patches/series      2015-02-03 
22:12:42.000000000 +0000
@@ -1,2 +1,3 @@
 01_fix-modplug-linking.patch
 02_opencv-linking.patch
+fix-segfault-varargs.patch
diff -Nru gst-plugins-bad1.0-1.4.4/debian/rules 
gst-plugins-bad1.0-1.4.4/debian/rules
--- gst-plugins-bad1.0-1.4.4/debian/rules       2014-11-06 11:48:08.000000000 
+0000
+++ gst-plugins-bad1.0-1.4.4/debian/rules       2015-02-03 22:24:37.000000000 
+0000
@@ -223,6 +223,7 @@
        for f in $(VERSIONIZE); do \
                rm -f debian/$(gst_pkgname)-$$f; \
        done
+       rm -f win32/common/config.h-new
 
 gst_patch = $(shell echo $(gst_version) | cut -d '.' -f 3)
 gst_patch_next = $(shell expr $(gst_patch) + 1)

--- End Message ---
--- Begin Message ---
Source: gst-plugins-bad1.0
Source-Version: 1.4.4-2.1

We believe that the bug you reported is fixed in the latest version of
gst-plugins-bad1.0, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 777...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Gilbert <mgilb...@debian.org> (supplier of updated gst-plugins-bad1.0 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 13 Feb 2015 19:45:44 +0000
Source: gst-plugins-bad1.0
Binary: gstreamer1.0-plugins-bad-doc gstreamer1.0-plugins-bad 
gstreamer1.0-plugins-bad-dbg libgstreamer-plugins-bad1.0-0 
libgstreamer-plugins-bad1.0-dev
Architecture: source all
Version: 1.4.4-2.1
Distribution: unstable
Urgency: medium
Maintainer: Maintainers of GStreamer packages 
<pkg-gstreamer-maintain...@lists.alioth.debian.org>
Changed-By: Michael Gilbert <mgilb...@debian.org>
Description:
 gstreamer1.0-plugins-bad - GStreamer plugins from the "bad" set
 gstreamer1.0-plugins-bad-dbg - GStreamer plugins from the "bad" set (debug 
symbols)
 gstreamer1.0-plugins-bad-doc - GStreamer documentation for plugins from the 
"bad" set
 libgstreamer-plugins-bad1.0-0 - GStreamer development files for libraries from 
the "bad" set
 libgstreamer-plugins-bad1.0-dev - GStreamer development files for libraries 
from the "bad" set
Closes: 777024
Changes:
 gst-plugins-bad1.0 (1.4.4-2.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Fix an incorrect function call on 32-bit architectures (closes: #777024).
Checksums-Sha1:
 edf19903410a5763cd058e4f5a73171d6d8045cd 4976 gst-plugins-bad1.0_1.4.4-2.1.dsc
 a2ed7e21e7107a3c4412faa46ced8025ab16b640 32260 
gst-plugins-bad1.0_1.4.4-2.1.debian.tar.xz
 f2a302ffda7204d72f78cbeed2ba26958bc6ce1e 1245114 
gstreamer1.0-plugins-bad-doc_1.4.4-2.1_all.deb
Checksums-Sha256:
 f9449cfa79ef4671eeee09287404a59ef22d067675104c6e4c6b7bbf4ee5b3d5 4976 
gst-plugins-bad1.0_1.4.4-2.1.dsc
 857dbbfb86a254f84f656ad221c1669eb55018bbabb1c0b587f16fe218c63185 32260 
gst-plugins-bad1.0_1.4.4-2.1.debian.tar.xz
 cacd0cec079710e894d16a6227f3829605aa2ba0888a72d628bc97c1db35708c 1245114 
gstreamer1.0-plugins-bad-doc_1.4.4-2.1_all.deb
Files:
 2a37e220808ecb85c30e7c4bdeb6b401 4976 libs extra 
gst-plugins-bad1.0_1.4.4-2.1.dsc
 b95907064b515d90e236c6e9d3632b0a 32260 libs extra 
gst-plugins-bad1.0_1.4.4-2.1.debian.tar.xz
 709af5c3186024bda71a7edc7718fd0b 1245114 doc extra 
gstreamer1.0-plugins-bad-doc_1.4.4-2.1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQQcBAEBCgAGBQJU3lrHAAoJELjWss0C1vRzVvAgAJzUB1OTkh3qRHHfNaM+6pst
rG3KvdXT0YwETpdUgUPZU8VntheR0YnsfGXPYotpjsgDXjkikjmr4I3ZtCriSRNv
7aq3eUA4KE5EM59xAYhtD5tcQjJ28dNEzbNZADWO1yGcCqD9MwpMRXj+Rfh/L2q3
3BMroqfZT8eVCBuz+2nLox0jO+bTzmf3U2ZMZRWUN5AP++G2N4MO0dwWjOwPwp0I
ZSpQ3ZdQvKFED6HYRrgM1birz7M7wyKYb00NOLL/gQOClBx8bGdf3CLvgM6REQgg
0RbqDwMCjPoLWIz1txB0bCV9PBJjTahX4MF5b4GJUSTi7/FeG2BBW7ebgeNU90Rl
xQgZF7S/6OmKCrpUQIeCwzByNznqNz9y9kIisclqEWyrODUklrVjJyfScneD2FML
mie2lWlZzC2nKksTIEWv04dhx6eXIYtjh2sFtKJOio6v62itQxhl3XUzbZ4Y4sKn
9Gvt60s0cPVL9/DgygP2o2K8Eokfg/fBbJfEFgCrtCOx18Zndoa1GajbHUOsnSto
GmWtGkbJSPGl6OoQS0jMg+XBBXCuJ/w66Ekm4iZQv3d9sThVg+79vnIqIwWpYPyz
qMJFk6X0NbGCutyAQaryIz9QEGUGguHVAcMUmSnntPZGEbhDqCgrW1D712Gsv3rr
6A3DicMeu4mBFhyEuexdUnBSIGelxPUoZ3UQt2+HoB7aAtf0K80uKqmFPIbrnojQ
neO/y5lCNwYPGqKsJ0ZX2tbQOmkIVKqpxhRWlINBnRRNt451gEhlZjfm6J/KOg26
qh3JiVYZgbLMyQcZVvqdYp9lm/bvxLYXMOse+1Gp9po3MpYe/HsuXnTn6RsDWyiH
zFuhSJ7CeXF9p9YuHxUheWGnLAzIMrFUKwekm/UTiHqoP/0L0VEenqNoAMNEICMJ
lyQ4Llwtc9Ne7ohzK5z2D2xsYW6vIhY3GcwnZP78UGyXRf3lr+wPl4BfqUErfY1H
HlQrj1NT8ZVgaoRQ29ER7tYJtuZY9nm+f/tdHNpYNcbK7Q1HhuTTTG7TjkA5YFJt
ZPYGrdUpc6rUC4HuwAslWLSk6fB+vjUyvdWKuK7UkWWl7l1z7zGpU64sIbVWsQPX
GpEx4nheRUlFXqnnXATKOeRNNMNQ/7aLt4NlxxoQA9cooXvbaEPesWmhZni+Q84D
czTPyaDZWFQbA/UfADx3/C68fJHMqTBzgFILsT9LSDc64r+yRR1lKHBVjXFTVHxY
076/wl+NF42fHnjYJkTdsN7ky5Co7OEaC/cPH3rrWBN4e8dl6ORfP3dpqyxa5aCS
hW5z+j9hWmGzwsCy8hR19vcW5xnQ+EQMkGAKScmoOnEceKiOndnbRai4v5Nw5bQ=
=j7wo
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to