Your message dated Sun, 15 Feb 2015 10:03:46 +0000
with message-id <e1ymw3g-00084x...@franck.debian.org>
and subject line Bug#772365: fixed in simpleburn 1.7.0-3
has caused the Debian Bug report #772365,
regarding simpleburn: bashism in /bin/sh script
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
772365: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=772365
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: simpleburn
Severity: serious
Version: 1.7.0-1
User: debian-rele...@lists.debian.org
Usertags: goal-dash
Hi,
I've ran checkbashisms (from the 'devscripts' package) over the whole
archive and I found that your package has a /bin/sh script that uses a
"bashism".
checkbashisms' output:
> possible bashism in ./usr/bin/simpleburn.sh line 3 ('function' is
useless):
> function printusage() {
> possible bashism in ./usr/bin/simpleburn.sh line 8 (echo -e):
> echo -e "usage: $0 [CD/DVD device] extract
> /path/to/audio_dir\n\t[format(wav|flac|ogg|mp3)\n\t\t[tracks(1,2,4-6,...)]\
> n\t]"
> possible bashism in ./usr/bin/simpleburn.sh line 9 (echo -e):
> echo -e "usage: $0 [CD/DVD device] extract /path/to/video_file
> title\n\t[quality(high|normal)\n\t\t[language(country-
code/aid)\n\t\t\t[sub
> titles(-1|country-
code/sid)\n\t\t\t\t[cropinfos(W:H:X:Y)]\n\t\t\t]\n\t\t]\n
> \t]"
> possible bashism in ./usr/bin/simpleburn.sh line 11 (echo -e):
> echo -e "usage: $0 [CD/DVD device] burn /path/to/audio_dir"
> possible bashism in ./usr/bin/simpleburn.sh line 20 ('function' is
> useless):
> function extractiso() {
> possible bashism in ./usr/bin/simpleburn.sh line 24 (let ...):
> let blockscount=mediasize/2048
> possible bashism in ./usr/bin/simpleburn.sh line 25 (let ...):
> let tracksize=mediasize/1024
> possible bashism in ./usr/bin/simpleburn.sh line 29 (should be 'b = a'):
> if [ "$opt" == "-cr" ]; then { sleep 5; simpleburn-gauges.sh dd
> $tracksize $LOCKFILE "$destination"; } & fi
> possible bashism in ./usr/bin/simpleburn.sh line 37 ('function' is
> useless):
> function expandtracks() {
> possible bashism in ./usr/bin/simpleburn.sh line 46 ('((' should be
'$(('):
> for ((i=firsttrack; i<=lasttrack; i++)); do
> possible bashism in ./usr/bin/simpleburn.sh line 62 ('function' is
> useless):
> function extractaudio() {
> possible bashism in ./usr/bin/simpleburn.sh line 69 (echo -e):
> tracklength=`echo -e $mediainfos | grep "^$track;" | cut
> -f3 -d';'`
> possible bashism in ./usr/bin/simpleburn.sh line 72 (let ...):
> let seconds=minutes*60+seconds
> possible bashism in ./usr/bin/simpleburn.sh line 74 (let ...):
> let total=total+seconds
> possible bashism in ./usr/bin/simpleburn.sh line 78 (let ...):
> let totaldone=0
> possible bashism in ./usr/bin/simpleburn.sh line 80 (let ...):
> let previouspercent=totaldone*100/total
> possible bashism in ./usr/bin/simpleburn.sh line 81 (let ...):
> let trackpercent=lengths[$track]*100/total
> possible bashism in ./usr/bin/simpleburn.sh line 82 (echo -e):
> title="$track-"`echo -e $mediainfos | grep "^$track;" | cut
> -f2 -d';' | sed 's@/@-@g'`
> possible bashism in ./usr/bin/simpleburn.sh line 83 ('((' should be
'$(('):
> if (( $track < 10 )); then title="0$title"; fi
> possible bashism in ./usr/bin/simpleburn.sh line 85 (should be 'b = a'):
> "wav") if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 88 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 88 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 94 (should be 'b = a'):
> "flac") if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 97 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 97 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 100 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 100 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 103 (should be 'b = a'):
> "ogg") if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 106 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 106 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 109 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 109 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 112 (should be 'b = a'):
> "mp3") if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 115 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 115 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 118 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 118 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 122 (let ...):
> let totaldone=totaldone+lengths[$track]
> possible bashism in ./usr/bin/simpleburn.sh line 130 ('function' is
> useless):
> function extractvideo() {
> possible bashism in ./usr/bin/simpleburn.sh line 147 (echo -e):
> titleinfos=`echo -e $mediainfos | grep "^$title;"`
> possible bashism in ./usr/bin/simpleburn.sh line 152 (should be 'b = a'):
> if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 156 (should be 'b = a'):
> if [ "$subtitles" == "-1" ]
> possible bashism in ./usr/bin/simpleburn.sh line 161 (should be 'b = a'):
> if [ "$quality" == "normal" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 168 (let ...):
> let totalrate=(audiorate+videorate)*1000/8 #kbits -> bytes
> possible bashism in ./usr/bin/simpleburn.sh line 169 (let ...):
> let totalsize=length*totalrate
> possible bashism in ./usr/bin/simpleburn.sh line 175 (should be 'b = a'):
> if [ "$opt" == "-cr" ]; then { sleep 5; simpleburn-gauges.sh
> mencoder $totalsize 1 $LOCKFILE-1 "$destination"; } & fi
> possible bashism in ./usr/bin/simpleburn.sh line 183 (should be 'b = a'):
> if [ "$opt" == "-cr" ]; then { sleep 5; simpleburn-gauges.sh
> mencoder $totalsize 2 $LOCKFILE-2 "$destination"; } & fi
> possible bashism in ./usr/bin/simpleburn.sh line 190 (should be 'b = a'):
> if [ "$subtitles" == "-1" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 191 (brace expansion):
> rm -f nosubs.{idx,sub}
> possible bashism in ./usr/bin/simpleburn.sh line 199 ('function' is
> useless):
> function burniso() {
> possible bashism in ./usr/bin/simpleburn.sh line 204 (let ...):
> let tracksize=tracksize/1048576 #MB
> possible bashism in ./usr/bin/simpleburn.sh line 205 (should be 'b = a'):
> if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 207 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 207 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 216 ('function' is
> useless):
> function burnaudio() {
> possible bashism in ./usr/bin/simpleburn.sh line 240 (let ...):
> let audiosize=audiosize/1048576
> possible bashism in ./usr/bin/simpleburn.sh line 242 (let ...):
> let totalsize=totalsize+audiosize
> possible bashism in ./usr/bin/simpleburn.sh line 244 (let ...):
> let totalsize=totalsize*913046 #1024x1024x2048/2352
> possible bashism in ./usr/bin/simpleburn.sh line 245 ('((' should be
> '$(('):
> if (( $totalsize > $mediacapacity )); then #final check due to
> conversion
> possible bashism in ./usr/bin/simpleburn.sh line 253 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 253 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 259 ('function' is
> useless):
> function burndata() {
> possible bashism in ./usr/bin/simpleburn.sh line 265 (let ...):
> let tracksize=tsize/512 #blocks => MB
> possible bashism in ./usr/bin/simpleburn.sh line 266 (should be 'b = a'):
> if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 268 ($PIPESTATUS):
> status=${PIPESTATUS[0]}&&${PIPESTATUS[1]}
> possible bashism in ./usr/bin/simpleburn.sh line 268 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}&&${PIPESTATUS[1]}
> possible bashism in ./usr/bin/simpleburn.sh line 271 ($PIPESTATUS):
> status=${PIPESTATUS[0]}&&${PIPESTATUS[1]}
> possible bashism in ./usr/bin/simpleburn.sh line 271 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}&&${PIPESTATUS[1]}
> possible bashism in ./usr/bin/simpleburn.sh line 286 (should be 'b = a'):
> if [ "$1" == "--help" ] || [ "$1" == "-h" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 291 (should be 'b = a'):
> if [ "$1" == "-cr" ]; then opt="-cr"; shift; fi
> possible bashism in ./usr/bin/simpleburn.sh line 298 (should be '.', not
> 'source'):
> source simpleburn-detect.sh $device
> possible bashism in ./usr/bin/simpleburn.sh line 319 (should be 'b = a'):
> if [ "$mediatype" == "none" ] || [ "$mediacontent" ==
> "blank" ] || [ "$mediacontent" == "udf" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 327 (should be 'b = a'):
> if [ -z "$audio" ]; then if [ "$LANG" ==
> "C" ]; then audio="en"; else audio=`echo $LANG | cut -c1-2`; fi; fi
> possible bashism in ./usr/bin/simpleburn.sh line 333 (echo -e):
> titleinfos=`echo -e $mediainfos | grep
> "^$title;"`
> possible bashism in ./usr/bin/simpleburn.sh line 359 ('((' should be
> '$(('):
> if (( $track < 1 )) || (( $track >
> $trackscount )); then echo "error: track '$track' not available"; exit 3;
> fi
> possible bashism in ./usr/bin/simpleburn.sh line 377 ('((' should be
> '$(('):
> if [ "$mediacontent" != "blank" ] && (( rewritablemedia ==
> 0 )); then
> possible bashism in ./usr/bin/simpleburn.sh line 391 ('((' should be
> '$(('):
> if [ "$mediatype" != "dvd" ] && (( `ls -l
> "$source"/*.wav 2>/dev/null | wc -l` != 0 )); then
> possible bashism in ./usr/bin/simpleburn.sh line 392 (let ...):
> let datasize=datasize*2048/2352
> possible bashism in ./usr/bin/simpleburn.sh line 395 ('((' should be
> '$(('):
> if (( $datasize > $mediacapacity )); then
> possible bashism in ./usr/bin/simpleburn.sh line 405 (should be 'b = a'):
> if [ "$mediacontent" != "blank" ] && [ "$mediatype" == "cd"
> ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 411 ('((' should be
> '$(('):
> if [ "$mediatype" == "dvd" ] || (( `ls -l
> "$source"/*.wav 2>/dev/null | wc -l` == 0 ))
> possible bashism in ./usr/bin/simpleburn.sh line 411 (should be 'b = a'):
> if [ "$mediatype" == "dvd" ] || (( `ls -l
> "$source"/*.wav 2>/dev/null | wc -l` == 0 ))
> possible bashism in ./usr/bin/simpleburn.sh line 429 ('function' is
> useless):
> function listps () {
> possible bashism in ./usr/bin/simpleburn-detect.sh line 3 ('function' is
> useless):
> function detect() {
> possible bashism in ./usr/bin/simpleburn-detect.sh line 25 (let ...):
> let mediacapacity=mediacapacity*2048
> possible bashism in ./usr/bin/simpleburn-detect.sh line 34 (let ...):
> let minutes=titlelenght/60
> possible bashism in ./usr/bin/simpleburn-detect.sh line 35 ('((' should be
> '$(('):
> if (( minutes > 3 )); then
> possible bashism in ./usr/bin/simpleburn-detect.sh line 36 ('((' should be
> '$(('):
> if (( $titlenum != 1 ));
> then
> possible bashism in ./usr/bin/simpleburn-detect.sh line 40 (let ...):
> let
> trackscount=trackscount+1
> possible bashism in ./usr/bin/simpleburn-detect.sh line 61 (should be 'b =
> a'):
> if [ "$id"
> == "ID_AID" ]
> possible bashism in ./usr/bin/simpleburn-detect.sh line 79 (let ...):
> let
> mediacapacity=mediacapacity*2048
> possible bashism in ./usr/bin/simpleburn-detect.sh line 84 (let ...):
> let mediasize=mediasize*2048
> possible bashism in ./usr/bin/simpleburn-detect.sh line 88 ('((' should be
> '$(('):
> for (( i=1; i<=$n; i++ )); do
> possible bashism in ./usr/bin/simpleburn-detect.sh line 108 (let ...):
> let mediasize_=mediasize/1048576
> possible bashism in ./usr/bin/simpleburn-detect.sh line 109 (let ...):
> let mediacapacity_=mediacapacity/1048576
> possible bashism in ./usr/bin/simpleburn-detect.sh line 125 (should be 'b
=
> a'):
> if [ "$1" == "--help" ] || [ "$1" == "-h" ]; then
> possible bashism in ./usr/bin/simpleburn-detect.sh line 130 (should be 'b
=
> a'):
> if [ "$1" == "-cr" ]; then opt="-cr"; shift; fi
> possible bashism in ./usr/bin/simpleburn-detect.sh line 148 (should be 'b
=
> a'):
> if [ `basename "'$0"` == "simpleburn-detect.sh" ]; then
> possible bashism in ./usr/bin/simpleburn-detect.sh line 150 (should be 'b
=
> a'):
> if [ "$opt" == "-cr" ]
> possible bashism in ./usr/bin/simpleburn-detect.sh line 152 (echo -e):
> echo -e $mediainfos
> possible bashism in ./usr/bin/simpleburn-detect.sh line 155 (echo -e):
> echo -e $detailedinfos
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 3 ('function' is
> useless):
> function mencodergauge () {
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 9 ('((' should be
> '$(('):
> if (( $pass == 0 ))
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 13 ('((' should be
> '$(('):
> if (( $pass == 1 ))
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 21 (let ...):
> let percent=(currentsize*passpercent/totalsize)+cumul
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 28 ('function' is
> useless):
> function ddgauge() {
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 35 (let ...):
> let filesize=filesize/1024
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 36 (let ...):
> let percent=(filesize*100)/totalsize
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 37 (let ...):
> let percent=percent%100
Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is the default /bin/sh.
Please closely examine the above output and the script, and determine
what the proper severity of the bug is, and adjust it accordingly. If
it's important or greater please hurry to get this fixed for jessie.
Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh
Thanks in advance,
Raphael Geissert
--- End Message ---
--- Begin Message ---
Source: simpleburn
Source-Version: 1.7.0-3
We believe that the bug you reported is fixed in the latest version of
simpleburn, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 772...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mateusz Łukasik <mat...@linuxmint.pl> (supplier of updated simpleburn package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 14 Feb 2015 15:46:32 +0100
Source: simpleburn
Binary: simpleburn
Architecture: source amd64
Version: 1.7.0-3
Distribution: unstable
Urgency: medium
Maintainer: Mateusz Łukasik <mat...@linuxmint.pl>
Changed-By: Mateusz Łukasik <mat...@linuxmint.pl>
Description:
simpleburn - Minimalistic application for burning and extracting CDs and DVDs
Closes: 772365
Changes:
simpleburn (1.7.0-3) unstable; urgency=medium
.
* Drop fix-bashisms.patch which contained errors and was
too invasive to be considered during the Jessie freeze.
* Add debian/patches/replace_shebangs.patch to replace all
#!/bin/sh shebangs with #!/bin/bash. (Closes: #772365)
Checksums-Sha1:
4d708d0c4c0a6ac946a7159ebc614f5893638751 1903 simpleburn_1.7.0-3.dsc
a06cce8d93b7722224fbbc5faf9080f2639b8c7e 38834 simpleburn_1.7.0.orig.tar.bz2
4940c54774cc7e4d1c8c6cfc93d56085e3ec4f4c 9568 simpleburn_1.7.0-3.debian.tar.xz
41f926dd1ce27c5f1719c64a7e6dda68cefaa43d 41438 simpleburn_1.7.0-3_amd64.deb
Checksums-Sha256:
eedd05d8c8c8b686d5d38b8aeaf1c3a6e163c970385c92e9af531bc019f98b3b 1903
simpleburn_1.7.0-3.dsc
5b1c2a57fd5b85998ffc7ad6c603fe2005fce47d8553271d288ca9402915c06e 38834
simpleburn_1.7.0.orig.tar.bz2
b68f4fc42f1e4f471b5beae4af35f406edfc88a81a68c755c3e1feff76a81a05 9568
simpleburn_1.7.0-3.debian.tar.xz
a3abfbe3f7da5e8b0b916d9139c6487f904bc73cd73da1a5377890ca7f499318 41438
simpleburn_1.7.0-3_amd64.deb
Files:
38c81a509dfb921a8641b49c305c6cc8 1903 utils extra simpleburn_1.7.0-3.dsc
dc22e612762da6774c8dbcc837a795fd 38834 utils extra
simpleburn_1.7.0.orig.tar.bz2
247f17c2ceed5421ed08cfda49e6880d 9568 utils extra
simpleburn_1.7.0-3.debian.tar.xz
1fece04c1b7798a3a7a61e2cac20abff 41438 utils extra simpleburn_1.7.0-3_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJU4G2SAAoJEHQmOzf1tfkTuX4P/RLeCgD16Cgrp131YIS3qb5j
mycH5L/s5xPxyX0cljU3Smkw/TLciMoY7aQklPHYtxxfMnqahpO9r2z3oSAxHlXU
unOORUp0YfULsgRi8mBZ3Ug4CTf//+pau0s5XwzokO2fJQmOZoNpuNFapjqwO0ZZ
09X4c08xTFojG/jqI6KvAN4N3ikR5Hi/zOhCsi/Jo2k0EW9VcNGnwIEX/w4l1WAX
jloYsoLYQBMQYjG0rrg43rP53js0/DfjeqThVwoI1q+XCh4CQ1lAym+8E+YR3pyO
zn6mcOPjRj/mwt2G2abMgB6WiIpL8QOh7sJ22oyG2AGwet181sBYCfOVPnfJxkkc
QQA5jEFfAa+AHqwMoahks914FbfBjtiEG7mdKtmFuYwtOs/BR/6/GUTZX4jRSIxg
vn99coVTFWka+nB+hxQFSTm9ZSkRxYpTNVzdAAfkV4j5nlNU/gHLjX/s098qkYz0
oOO29MhWwQlwL08TYlNUtFOTepBlSiCcs3qpBz0WIELGZjI+g6AqWBjblphGnSrg
+ZBK0BnKH4W357w6lQKyW1xrCvF982d4Ivl9Fv+1otFfAHcXWc4/txdHJSIZgXHQ
ZXk8NAmjv7DPHcVDYpdHCa7qaD0vCCON5tCuNwrSnlspogWDnQniS1XXO4hxb3Ln
gxJ9YbAdcssOCeSLuCR9
=lVsO
-----END PGP SIGNATURE-----
--- End Message ---
