Your message dated Sat, 07 Feb 2015 18:48:31 +0000
with message-id <e1ykaqh-0003lj...@franck.debian.org>
and subject line Bug#689887: fixed in distmp3 0.1.9.ds1-4.5
has caused the Debian Bug report #689887,
regarding Ships a folder in /var/run or /var/lock (Policy Manual section 9.3.2)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
689887: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=689887
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: distmp3
Version: 0.1.9.ds1-4.4
Severity: serious
Tags: patch

Dear Maintainer,

Andreas Beckmann <deb...@abeckmann.de> reported in -devel that your package
(as well as 27 others) ships a folder either in /var/run or /var/lock. This
is forbidden by policy.

Lintian detects the problem and warns as follow:

/var/run may be a temporary filesystem, so any directories or files needed
/there must be created dynamically at boot time.

Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for
details.

Severity: serious, Certainty: possible
Check: files, Type: binary, udeb

which is why I am reporting this bug with severity serious (and there fore,
release critical).

Please fix your package. I have attached what I believe is a good fix the
problem, however, I haven't tried it, and I haven't tested if something more
for creating the necessary folder at runtime should be added. Please make
sure to test before applying the patch blindly.

Cheers,

Thomas Goirand (zigo)
diff -u distmp3-0.1.9.ds1/debian/rules distmp3-0.1.9.ds1/debian/rules
--- distmp3-0.1.9.ds1/debian/rules
+++ distmp3-0.1.9.ds1/debian/rules
@@ -17,7 +17,7 @@
 	dh_testroot
 	dh_clean -k
 	
-	dh_installdirs /usr/bin /etc /var/run/distmp3
+	dh_installdirs /usr/bin /etc
 	
 	install -m 755 distmp3 debian/distmp3/usr/bin
 	install -m 755 distmp3host debian/distmp3/usr/bin
diff -u distmp3-0.1.9.ds1/debian/distmp3.postinst distmp3-0.1.9.ds1/debian/distmp3.postinst
--- distmp3-0.1.9.ds1/debian/distmp3.postinst
+++ distmp3-0.1.9.ds1/debian/distmp3.postinst
@@ -18,8 +18,6 @@
     adduser --quiet --system --home /nonexistent --disabled-password \
             --no-create-home --group distmp3
   fi
-
-  chown $USER:$USER /var/run/distmp3
 fi
 
 #DEBHELPER#
diff -u distmp3-0.1.9.ds1/debian/changelog distmp3-0.1.9.ds1/debian/changelog
--- distmp3-0.1.9.ds1/debian/changelog
+++ distmp3-0.1.9.ds1/debian/changelog
@@ -1,3 +1,10 @@
+distmp3 (0.1.9.ds1-4.5) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fixes bad handling of /var/run/distmp3 life cycle (Closes: #XXXXXX).
+
+ -- Thomas Goirand <z...@debian.org>  Sat, 06 Oct 2012 16:43:30 +0800
+
 distmp3 (0.1.9.ds1-4.4) unstable; urgency=low
 
   * Non-maintainer upload.
diff -u distmp3-0.1.9.ds1/debian/distmp3.init distmp3-0.1.9.ds1/debian/distmp3.init
--- distmp3-0.1.9.ds1/debian/distmp3.init
+++ distmp3-0.1.9.ds1/debian/distmp3.init
@@ -33,6 +33,13 @@
         
 set -e
 
+if [ ! -d /var/run/distmp3 ] ; then
+	mkdir -p /var/run/distmp3 || true
+	if [ -d /var/run/distmp3 ] ; then
+		chown distmp3:distmp3 /var/run/distmp3
+	fi
+fi
+
 case "$1" in
   start)
 	echo -n "Starting $DESC: $NAME"
only in patch2:
unchanged:
--- distmp3-0.1.9.ds1.orig/debian/distmp3.postrm
+++ distmp3-0.1.9.ds1/debian/distmp3.postrm
@@ -0,0 +1,10 @@
+#!/bin/sh
+
+set -e
+
+if [ "${1}" = "purge" ] ; then
+	rm -rf /var/run/distmp3
+fi
+
+#DEBHELPER#
+

--- End Message ---
--- Begin Message ---
Source: distmp3
Source-Version: 0.1.9.ds1-4.5

We believe that the bug you reported is fixed in the latest version of
distmp3, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 689...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Beckmann <a...@debian.org> (supplier of updated distmp3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 28 Jan 2015 18:50:19 +0100
Source: distmp3
Binary: distmp3
Architecture: source all
Version: 0.1.9.ds1-4.5
Distribution: unstable
Urgency: medium
Maintainer: Jesus Climent <jesus.clim...@hispalinux.es>
Changed-By: Andreas Beckmann <a...@debian.org>
Description:
 distmp3    - A Perl client and daemon for distributed audio encoding
Closes: 668736 689887
Changes:
 distmp3 (0.1.9.ds1-4.5) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Let the initscript create /var/run/distmp3/.  (Closes: #689887)
   * Remove /etc/default/distmp3 on purge.  (Closes: #668736)
Checksums-Sha1:
 ba4bdd461960566e1e5b5c894e9d8e5b8d614c36 1705 distmp3_0.1.9.ds1-4.5.dsc
 5a153febf4956c2eff64b663c51de9d0621c8a1a 18154 distmp3_0.1.9.ds1-4.5.diff.gz
 5e7b270c2cbe4e6d3deb937e73742c8577918b10 21380 distmp3_0.1.9.ds1-4.5_all.deb
Checksums-Sha256:
 3958c083045e659a4bd663a5722fd28adbd00897d46a9e94650aef2772aa49aa 1705 
distmp3_0.1.9.ds1-4.5.dsc
 5941e8f59f094197c85042563d322c955ba6e97580c336771de303da74f2e51f 18154 
distmp3_0.1.9.ds1-4.5.diff.gz
 c4e56cd8f87b0d9505450a1badaf0a9c1aca1bf0eabd07f9dbb8bb976dfd6d73 21380 
distmp3_0.1.9.ds1-4.5_all.deb
Files:
 a81b373b8daeb2139abfae277b2292ee 1705 sound optional distmp3_0.1.9.ds1-4.5.dsc
 0b08a1a0b1d5db29270170ec13591b11 18154 sound optional 
distmp3_0.1.9.ds1-4.5.diff.gz
 ced062532146eb977904a2b13a19a934 21380 sound optional 
distmp3_0.1.9.ds1-4.5_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJUySJbAAoJEF+zP5NZ6e0I0OkP/2OSjZQIzp8vcvagpp9ymvLB
Z1KfWQmhg9xIljO4yXqHV4r/JZ+zgHy2pqxg1RjFvpzME4uqXd6C6dirNNgv40QX
MJClDspDG5ty2FrAqhq2VR4Hy6Xic6med4vl9dlM9Yz9lT6ODm/Gbp5kcrSnArVm
bjv8vdsePDtdhpDlIbEYLvMTH/FVZNcMIoCc7z835Ays9/XO7jtpAx3w9qYDCDrY
6ckHdMlejujImc9R0g8+HMBIr9m2hmAm+L4kmEQH9qeMRLrYHbmo2Fld3OMVgi5M
mYTGy9uUtS9tyG3I1Ak33a1HSizRcxW6Sg1CB/6ESURljpHcPatlVdee24dtH87h
e8S82M35k9NL0XcCsNZ6siKpVzWy63+2SQWt//1WOBg0g31HjQq3RjvFWPDQSYXI
l0QxBsttUe5K3pFuo3lLxD96D8L0KeTX2/DgdbA9drnBmhx4mPxiOSUlMvVubeYy
iIm29PJJRaVIVDbNaPRld5zcrGcot0s6i9Al9+nW1Ujr2VRzYnhxtAFgnDdLj5oJ
sfbyq3X58Q6TS5+UeACMYa7UKa8N8iWUuSHBQHOiqBv59L5u45EH4hlcwIJR2I75
b2aDmTMnrwoaqfRd2pn6S2ytyYPrKSWVm4U6isjrOcE8XEyww/BYKaiTYdfz+EIj
gp9YsXeCvqVJhBgYQeKw
=SBGh
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to