Package: libblkid-dev
Version: 2.25.2-4
Severity: serious
User: debian...@lists.debian.org
Usertags: piuparts

Hi,

an upgrade test with piuparts revealed that your package installs files
over existing symlinks and possibly overwrites files owned by other
packages. This usually means an old version of the package shipped a
symlink but that was later replaced by a real (and non-empty)
directory. This kind of overwriting another package's files cannot be
detected by dpkg.

This was observed on the following upgrade paths:

  lenny -> squeeze -> wheezy -> jessie

The bug dates back to the lenny->squeeze upgrade cycle. The lenny version
of the package shipped
  /usr/share/doc/libblkid-dev -> libblkid1
while in squeeze this was replaced by a directory, but the symlink
got never transitioned, so the problem persists in long grown
installations until today.

For /usr/share/doc/PACKAGE this may not be problematic as long as both
packages are installed, ship byte-for-byte identical files and are
upgraded in lockstep. But once one of the involved packages gets
removed, the other one will lose its documentation files, too,
including the copyright file, which is a violation of Policy 12.5:
https://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile

For other overwritten locations anything interesting may happen.

Note that dpkg intentionally does not replace directories with symlinks
and vice versa, you need the maintainer scripts to do this.
See in particular the end of point 4 in
https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-unpackphase

It is recommended to use the dpkg-maintscript-helper commands
'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.14)
to perform the conversion, ideally using d/$PACKAGE.mainstscript.
Do not forget to add 'Pre-Depends: ${misc:Pre-Depends}' in d/control.
See dpkg-maintscript-helper(1) and dh_installdeb(1) for details.


>From the attached log (usually somewhere in the middle...):

5m26.4s ERROR: FAIL: silently overwrites files via directory symlinks:
  /usr/share/doc/libblkid-dev/changelog.Debian.gz (libblkid-dev:amd64) != 
/usr/share/doc/libblkid1/changelog.Debian.gz (libblkid1:amd64)
    /usr/share/doc/libblkid-dev -> libblkid1
  /usr/share/doc/libblkid-dev/changelog.gz (libblkid-dev:amd64) != 
/usr/share/doc/libblkid1/changelog.gz (libblkid1:amd64)
    /usr/share/doc/libblkid-dev -> libblkid1
  /usr/share/doc/libblkid-dev/copyright (libblkid-dev:amd64) != 
/usr/share/doc/libblkid1/copyright (libblkid1:amd64)
    /usr/share/doc/libblkid-dev -> libblkid1

5m33.5s ERROR: FAIL: After purging files have disappeared:
  /usr/share/doc/libblkid1/changelog.Debian.gz   owned by: libblkid1:amd64
  /usr/share/doc/libblkid1/changelog.gz  owned by: libblkid1:amd64
  /usr/share/doc/libblkid1/copyright     owned by: libblkid1:amd64

It's sufficient to fix this in jessie, no need to backport the fix
to wheezy (which does not have dpkg-maintscript-helper symlink_to_dir).


cheers,

Andreas

Attachment: libblkid-dev_2.25.2-4.log.gz
Description: application/gzip

Reply via email to