severity 774464 normal
thanks

Well, until the commit referred to above the default document root *was*
/usr/share/nginx/html :

diff --git a/debian/conf/sites-available/default
b/debian/conf/sites-available/default
index f6413f0..406c754 100644
--- a/debian/conf/sites-available/default
+++ b/debian/conf/sites-available/default
@@ -21,7 +21,7 @@ server {
  listen 80 default_server;
  listen [::]:80 default_server ipv6only=on;

- root /usr/share/nginx/html;
+ root /var/www/html;
  index index.html index.htm;

  # Make site accessible from http://localhost/

I entirely agree this change is valid and users shouldn't meddle with
/usr/share,
but given that this used to be the default configuration I'd say it'd be
good to be
more forgiving.


Kind regards,

Arnout

On Thu, Jan 8, 2015 at 2:05 AM, Michael Lustfield <mich...@lustfield.net>
wrote:
>
> I can understand the concern about loss.
>
>
>
> However, /usr/share/ is for packages. This is where packages put things.
This
>
> is essentially a web app installed and maintained by the nginx-common
package.
>
> It is *not* a configuration file. There is no need to handle it as if it
were a
>
> configuration file.
>
>
>
> Let's look at every other package that sticks an app in /usr/share. I'm
only
>
> going to pick one - phpmyadmin.
>
>
>
> If you modify /usr/share/phpmyadmin/libraries/export/mediawiki.php and
then
>
> upgrade, your changes are gone. That's expected behavior.
>
>
>
> Users/admins should *NOT* be screwing with /usr/share. That's why this
file is
>
> there... it's managed by the package and NOT the user. That's also part of
>
> the reason why we don't stick the symlink for the default site back into
>
> sites-enabled once it's removed.
>
>
>
> I strongly disagree with the severity change. However, I'll leave it as I
feel
>
> we should just close this as wontfix. Someone incorrectly using /usr/share
>
> isn't our issue to fix.
>
>
>
> On Thu, 8 Jan 2015 01:03:15 +0100
>
> Arnout Engelen <arn...@bzzt.net> wrote:
>
>
>
> > severity 774464 grave
>
> > thanks
>
> >
>
> > Updating the severity to 'grave' because of data loss: looks like the
>
> > user-modified index.html really is lost.
>
> >
>
> > On Sat, Jan 3, 2015 at 3:35 AM, Arnout Engelen <deb...@bzzt.net> wrote:
>
> >
>
> > > Package: nginx
>
> > > Version: 1.6.2-5
>
> > > Severity: normal
>
> > >
>
> > > Dear Maintainer,
>
> > >
>
> > > After just upgrading nginx from the version in raspbian wheezy to the
one
>
> > > in
>
> > > jessie it appears my removed my (modified)
/usr/share/nginx/www/index.html
>
> > > and
>
> > > replaced it by a (default/original) /usr/share/nginx/html/index.html .
>
> > >
>
> > > Could perhaps be related to
>
> > >
http://anonscm.debian.org/cgit/collab-maint/nginx.git/commit/?id=74531a5070ac96a5e3c75bec2a19871c65e07446
>
> > > ?
>
> > >
>
> > >
>
> > > -- System Information:
>
> > > Distributor ID: Raspbian
>
> > > Description:    Raspbian GNU/Linux testing (jessie)
>
> > > Release:        testing
>
> > > Codename:       jessie
>
> > > Architecture: armv6l
>
> > >
>
> > > Kernel: Linux 3.12.35+ (PREEMPT)
>
> > > Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
>
> > > Shell: /bin/sh linked to /bin/dash
>
> > > Init: systemd (via /run/systemd/system)
>
> > >
>
> > > Versions of packages nginx depends on:
>
> > > ii  nginx-full  1.6.2-5
>
> > >
>
> > > nginx recommends no packages.
>
> > >
>
> > > nginx suggests no packages.
>
> > >
>
> > > -- no debconf information
>
> > >
>
>
>
>
>
> --
>
> Michael Lustfield
>

Reply via email to