Hello, On Tue, 23 Dec 2014, Thorsten Alteholz wrote: > On Tue, 23 Dec 2014, Nguyen Cong wrote: > >I have created .deb file for ettercap package. > > great, thanks alot. > > >Since I'm not DD or DM so I attached debdiff file for review > >as mentioned in LTS/Development wiki page. > >Could anyone please check it and tell me if any comments? > > After a first glimpse it seems to be that this package uses quilt, but you > directly changed the source files. Please don't change the way of the > original maintainer to handle patches.
It looks like the upstream author made the same mistake when preparing an upload of his own in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=773416#50 I propose to let Nguyen Cong take care of fixing this so that he can learn about quilt and have some easy entry into contributing to the LTS team. Nguyen, feel free to get some inspiration from Gianfranco's more verbose changelog message though. :) Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/ -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
