Your message dated Sat, 06 Dec 2014 18:17:53 +0100
with message-id <9861560.2cVtvP29aO@eee>
and subject line Re: Re: Bug#772239: git-remote-gcrypt: bashism in /bin/sh
script
has caused the Debian Bug report #772239,
regarding git-remote-gcrypt: bashism in /bin/sh script
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
772239: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=772239
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: git-remote-gcrypt
Severity: serious
Version: 0.20130908-7
User: debian-rele...@lists.debian.org
Usertags: goal-dash
Hi,
I've ran checkbashisms (from the 'devscripts' package) over the whole
archive and I found that your package has a /bin/sh script that uses a
"bashism".
checkbashisms' output:
> possible bashism in ./usr/bin/git-remote-gcrypt line 102 (setvar 'foo'
> 'bar' should be eval 'foo="'"$bar"'"'):
> setvar "$1" "$f_append_tmp_$2"
> possible bashism in ./usr/bin/git-remote-gcrypt line 117 (setvar 'foo'
> 'bar' should be eval 'foo="'"$bar"'"'):
> setvar "$1" "${f_ret#$Newline}"
> possible bashism in ./usr/bin/git-remote-gcrypt line 135 (setvar 'foo'
> 'bar' should be eval 'foo="'"$bar"'"'):
> setvar "$1" "${f_ret%$Newline}"
> possible bashism in ./usr/bin/git-remote-gcrypt line 418 (setvar 'foo'
> 'bar' should be eval 'foo="'"$bar"'"'):
> setvar "$1" "$good_sig"
> possible bashism in ./usr/bin/git-remote-gcrypt line 419 (setvar 'foo'
> 'bar' should be eval 'foo="'"$bar"'"'):
> setvar "$2" "$signers_"
> possible bashism in ./usr/bin/git-remote-gcrypt line 462 (setvar 'foo'
> 'bar' should be eval 'foo="'"$bar"'"'):
> setvar "$1" "$good_sig"
> possible bashism in ./usr/bin/git-remote-gcrypt line 463 (setvar 'foo'
> 'bar' should be eval 'foo="'"$bar"'"'):
> setvar "$2" "$signers_"
> possible bashism in ./usr/bin/git-remote-gcrypt line 636 (setvar 'foo'
> 'bar' should be eval 'foo="'"$bar"'"'):
> setvar "$1" "$r_del_list"
Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is the default /bin/sh.
Please closely examine the above output and the script, and determine
what the proper severity of the bug is, and adjust it accordingly. If
it's important or greater please hurry to get this fixed for jessie.
Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh
Thanks in advance,
Raphael Geissert
--- End Message ---
--- Begin Message ---
Hi Joey,
On Saturday 06 December 2014 12:36:37 Joey Hess wrote:
> Raphael Geissert wrote:
> > checkbashisms' output:
> > > possible bashism in ./usr/bin/git-remote-gcrypt line 102 (setvar 'foo'
> > > 'bar' should be eval 'foo="'"$bar"'"'):
> > > setvar "$1" "$f_append_tmp_$2"
>
> Why?
>
> setvar()
> {
> isnull "${1##@*}" || echo_die "Missing @ for return variable: $1"
> eval ${1#@}=\$2
> }
>
> AFAICS, setvar is not a bash builtin at al.
Given that the function defined by the script, this is a false positive.
setvar is a feature that is provided by some ksh implementations IIRC, and
that might have been added to other shells.
Apologies for the noise.
Cheers,
--
Raphael Geissert
--- End Message ---
