On Mon, Nov 17, 2014 at 11:42:54PM +0100, Jean Baptiste Favre wrote: > Thanks for your advice. I'm working on a new version of the patch. > In the meantime, what should I do with my already uploaded NMU (on > mentors.debian.net). Maybe I should delete it just to be sure nobody > will upload it ?
You can do that. > I also noticed that init scripts ask for "dpkg-reconfigure package" to > enable service start, which is disabled by default. I guess this was OK > when debconf handles /etc/default/package content, but obviously it > won't work anymore. > I can change the init script to display another message. This sounds like a documentation fix. Currently, this should be covered by the freeze policy. So fixing it should be ok for now. > Finally, I'm considering shipping /etc/default/ola which is not shipped > currently, in the same way as /etc/default/ola-rdm-tests. It controls > whether olad service is enabled or not. This sounds like a functional change. While it looks like an improvement, I do not yet see why this should be release critical. So better skip this for the upload targeting jessie, but you can prepare a separate .debdiff for Wouter to apply later if you like. (Better create a new bug report at lower severity then.) > And, last question, speaking about /etc/default files, I wonder which > are the best practices: > - name /etc/default/xxx file according to the init script which will use > them > - name /etc/default/xxx file according to the package which provide them > > In my case, /etc/default/ola is provided by ola package but controls > olad service. Same with /etc/default/ola-rdm-tests which is provided by > eponym package to control rdm_test_server service. > > All these would indeed increase the overall package quality, but I > wonder if this is not a bit "out of scope" work considering Jessie freeze. You are rightly wondering. These changes are likely not acceptable for jessie. It looks to me that you are looking a bit too far at the moment. This bug was found using piuparts. After applying your initial .debdiff, piuparts still rightfully complains (about other things). This is why I asked you to reiterate. Nothing more. Helmut -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
