On Wed, 12 Nov 2014 21:11:09 +0000, Simon McVittie wrote:

> Since this is, strictly speaking, a regression in our patched
> CGI::FormBuilder, I've prepared a patch that replaces Amitai's 2
> patches, and my additional patch in the same style. (See attached,
> 0003-*.patch.)

Thank you, much appreciated.
 
> The best way to do this upstream would probably be to add a new function
> Util::param_multi_valued($cgi_or_compatible, $k) encapsulating that
> logic, but that's new API, which seems undesirable to add downstream;
> that's also a reasonable argument for not adding
> Catalyst::Request::param_fetch unless/until Catalyst upstream say yes, I
> suppose.

Agreed on both accounts.
 
> The attached 0001-*.patch is for Debian's git repo. The patched
> libcgi-formbuilder-perl passes its tests in sbuild, and so does
> libcatalyst-controller-formbuilder-perl_0.06-2 when given the patched
> libcgi-formbuilder-perl as an additional .deb.

Thanks.

Jonas, do you have time to look into this?


Cheers,
gregor
 
-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Element of Crime: Wenn der Winter kommt

Attachment: signature.asc
Description: Digital Signature

Reply via email to