Le 09/11/2014 13:51, Laurent Bigonville a écrit : > OK, I'm thinking about the attached patch to fix this issue. > > The initial answer on the unblock bug was quite negative about > splitting the package (this could still be done in next (Stretch)) > release. This patch is less invasive and has higher chances of being > accepted. > > The only issue of not having the label.so file installed in the > initramfs is the fact that some text might not be displayed (according > to upstream). > > What do you think?
This patch will indeed fix the bug (ie. preventing the initramfs update to crash), but if the user isn't careful and doesn't read the warning, (s)he won't understand why there's no text during boot. This can be problematic with encrypted fs, as there won't be any prompt to enter the passphrase, nor any indication if the passphrase, assuming it was typed blindly, worked or not (I can't test this precise case atm because my encrypted laptop is still in wheezy). I'm not sure that such a behavior would be acceptable for a stable release. In addition to that patch, modifying /usr/sbin/plymouth-set-default-theme to revert to the default (text) theme if label.so is missing would be a good thing; that way, if the user uses plymouth-set-default-theme to change the theme, it will automatically revert to a text theme and there won't be any passphrase problem; if (s)he modifies /etc/plymouth/plymouthd.conf directly, we can assume (s)he knows what (s)he's doing and won't miss the warning during update-initramfs. Also, a hint to where to find label.so ("Please install plymouth-themes", which could be changed to "Please install plymouth-label" in Jessie+1 when the additional package will exist) would be a good thing too. Regards, -- Raphaël HALIMI
signature.asc
Description: OpenPGP digital signature