Your message dated Sun, 02 Nov 2014 16:04:48 +0000
with message-id <e1xkxe4-00067b...@franck.debian.org>
and subject line Bug#767755: fixed in performous 0.7.0+git20140715-2
has caused the Debian Bug report #767755,
regarding performous-tools: ss_extract and ss_cover_conv binaries are not built 
due to broken ImageMagick detection
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
767755: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767755
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: performous-tools
Version: 0.7.0+git20140715-1+b3
Severity: serious
Tags: patch


Currently the ss_extract and ss_cover_conv binaries are not shipped
with the performous-tools package which is a regression. I did not
willfully drop the binaries and it seems the detection of ImageMagick
libraries has been broken for some time.

Those libraries are no longer detected at build time and since they
are only optional the aforementioned binaries are not built anymore. I
assume the latest changes in ImageMagick and the corresponding
transition are reponsible for this change which went completely
unnoticed.

I consider this issue release critical because it was never the
intention to drop those binaries. Patch is attached.

Markus
From: Markus Koschany <a...@gambaru.de>
Date: Sun, 2 Nov 2014 13:44:14 +0100
Subject: fix imagemagick detection

Fix the detection of the ImageMagick library for Debian systems which use
Multiarch paths. That ensures that ss_extract and ss_cover_conv are built
again.

Forwarded: https://github.com/performous/performous/pull/113
---
 tools/CMakeLists.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/CMakeLists.txt b/tools/CMakeLists.txt
index 50bdd6f..8c0d468 100644
--- a/tools/CMakeLists.txt
+++ b/tools/CMakeLists.txt
@@ -21,13 +21,17 @@ if (APPLE)
     find_package(ImageMagick COMPONENTS Magick++)
     include_directories(${ImageMagick_INCLUDE_DIRS})
 else (APPLE)
-    foreach(lib LibXML++ Z Magick++ Jpeg Tiff Png Freetype Z)
+    foreach(lib LibXML++ Z Jpeg Tiff Png Freetype Z)
 	    find_package(${lib})
     	if (${lib}_FOUND)
 	    	include_directories(${${lib}_INCLUDE_DIRS})
 		    add_definitions(${${lib}_DEFINITIONS})
     	endif (${lib}_FOUND)
     endforeach(lib)
+
+    find_package(ImageMagick COMPONENTS Magick++)
+    find_package(PkgConfig)
+    PKG_CHECK_MODULES(IMAGEMAGICK Magick++ MagickWand MagickCore)
 endif (APPLE)
 
 # Set default compile flags for GCC

--- End Message ---
--- Begin Message ---
Source: performous
Source-Version: 0.7.0+git20140715-2

We believe that the bug you reported is fixed in the latest version of
performous, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 767...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Markus Koschany <a...@gambaru.de> (supplier of updated performous package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 02 Nov 2014 13:46:41 +0100
Source: performous
Binary: performous performous-tools performous-dbg
Architecture: source
Version: 0.7.0+git20140715-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-de...@lists.alioth.debian.org>
Changed-By: Markus Koschany <a...@gambaru.de>
Description:
 performous - karaoke game that allows user supplied songs
 performous-dbg - karaoke game that allows user supplied songs - debug
 performous-tools - karaoke game that allows user supplied songs - tools
Closes: 699400 767755
Changes:
 performous (0.7.0+git20140715-2) unstable; urgency=medium
 .
   * Add fix-imagemagick-detection.patch. (Closes: #767755)
     Detect ImageMagick library and build the ss_extract and ss_cover_conv
     binaries again which were accidentally dropped.
   * Add use-avconv.patch. (Closes: #699400)
     Replace ffmpeg command with avconv for ss_extract tool because ffmpeg
     will not be available for Jessie.
   * performous-tools: Depend on libav-tools because ss_extract requires
     the avconv command.
   * Move the package to Git. Change Vcs fields accordingly.
Checksums-Sha1:
 d942fcc8d0d1c405da6d7295bf7dc731131b416d 2606 
performous_0.7.0+git20140715-2.dsc
 41d5eb85122e9e4c188a59f0568f739c8ef5090a 14232 
performous_0.7.0+git20140715-2.debian.tar.xz
Checksums-Sha256:
 44f7f9d9e7182a7e4e29c47e5019aff1d68939e84bad7a2084ba4d9fb1d9510f 2606 
performous_0.7.0+git20140715-2.dsc
 059dc7f4a77947bef7806146c782afa394f2d7d69bfc87e9eb3804a0a9c5b9de 14232 
performous_0.7.0+git20140715-2.debian.tar.xz
Files:
 0dcbae17a154e679c040e72f39ad7e6e 2606 games optional 
performous_0.7.0+git20140715-2.dsc
 03ef500bcb0698c14b6a18c81cf9a27f 14232 games optional 
performous_0.7.0+git20140715-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQJ8BAEBCgBmBQJUVkt1XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBQ0YzRDA4OEVGMzJFREVGNkExQTgzNUZE
OUFEMTRCOTUxM0I1MUU0AAoJENmtFLlRO1HkoagQAMxEeP7Q4uXNlR2imtZllmcm
LvOEdjlD0/hHmoSooW79ibL5JK05dYWb4r77qwA29LEqLw7WodFwEUeAcx6iYGNn
n0fJeP41Bx/Sui8FJrx8vCOvwf1diJfeBzSchl91nQKrPdWI+KB5UK2lzNHDxHqq
f+ypkebvc1Dc+HGzpl4C3qiLVpOMovuTs/vxjo+f0P0ijIIBw1FAKibefnQA6qsu
Hkiof8stIIWehVyF3efkyDxuKl/7QacdpsbsCsqCnzylqVUyYAffsds4ussK+pqg
WntVMa7QrOH737992S1b/GT1H7p6MIVkNUpxQghVa6YVnqNGsb9nDW1YOZ+d1Nde
h7NuYCfGf3utJwn4XvWZWIjWcSWh8MUGkieYKEQMSTYt87YE1wqcPMMqWWTRQ+gi
DkoQbyngoWbVIh0/wmQ32iISNPa3rdpR5KhwjjyjcNPieXZLSu5vwzSY7Rf7uWWV
tvChV3qYratdzC0Q3lADtmVtU/YKACJIMzgzRV43eq0QA/9qIRcfhXEXA6oNQ1vd
yvuSvsJ+rTovx36yP2BZkOOoOJxYbruQbZNh/MhoTBRaEZQn71+JQ1HXj/+tbyzf
idxw5A2aC923WBQ2u26aEIk1Ar8op6dotJS1T/tPFXTXuYDIXgm00SBqwllBhGu4
3bC8WhLHl9iBYa8nJDBC
=TUYx
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to