Hi Dominik,
As I already stated in my previous mail to this bug, I don't think the
issue is really in the part that you were patching. (At least, when I
installed roundcube-core, that part was not used.) The area that you
were patching is only for manual use, and you can argue that that part
is thus not RC (I don't think it is the best we can do, but let's not
fix that now during the freeze). I believe that ucf should not change
any permissions, but I hope the ucf maintainer can respond to that.
However, apart from that, if you had local changes, ucf will happily
move the $tmpout to ${outputfile}.ucf-dist and I rather have that file
to have the same permissions/ownership. Therefor, I think the following
patch is the best that we can do as it does solve the above issue and
work around the, in my opinion, buggy behavior of ucf. Am I overlooking
something?
Paul
diff --git a/dbconfig-generate-include b/dbconfig-generate-include
index de15752..b21e46f 100755
--- a/dbconfig-generate-include
+++ b/dbconfig-generate-include
@@ -222,6 +222,11 @@ if [ "$outputfile" ]; then
echo "unable to create temporary file $tmpout" >&2
exit 1
fi
+ if [ -e "$outputfile" ] ; then
+ # In order to preserve all local attributes of the
+ # original file, copy it, we are filling it from scratch
+ cp --preserve=all "$outputfile" "$tmpout"
+ fi
exec > $tmpout
fi
signature.asc
Description: OpenPGP digital signature
