On Wed, Dec 28, 2005 at 07:50:20PM +0100, Bastian Blank wrote:
> >    * Apply Steve Langasek's suggestion to fix the build failures on 64-bit
> >      machines by explicitly adding a uint64_t variant of
> >      XmlFileWriter::element. (Closes: #337820)

> This will not fix this bug. s390 have size_t == signed int.

Hrm, that doesn't make any sense.  The previous set of implementations were

                void element(const std::string &name, const std::string &value);
                void element(const std::string &name, const char        *value);
                void element(const std::string &name, int                value);
                void element(const std::string &name, unsigned int       value);
                void element(const std::string &name, bool               value);

If size_t == signed int, why did the third of these not match automatically?
Where's the ambiguity?

> Is there any reason to not provide only versions for bool and size_t?

Given that there are other integer types being passed to this function which
aren't size_t, wouldn't we have the same disambiguation problem between bool
and size_t for them?  AFAICT, if we want special handling for bool, the only
way to deal with this is by overloading *all* the integer types, rather than
only one of them; but then I still don't know why s390 is failing. :/

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
[EMAIL PROTECTED]                                   http://www.debian.org/

Attachment: signature.asc
Description: Digital signature

Reply via email to