2014-10-09 16:33 GMT+04:00, jre <jre.wine...@gmail.com>: > Most parts of your patch aren't related to this bug but simply use > another style (replacing spaces with tabs; using bash builtins [ ] > instead of test (I would prefer that too); omitting "&&" (bad idea)). > > As already noted previously the patch for this bug is really just adding > the missing "fi" (haven't tested it, but it seems obvious). > > Please search the web how to submit correct patches. Basically you > should keep them minimal and adapt to the current style of the file that > you want to patch. > > If you want other things changed in wine file another bug with your > patch and describe what you did there for what purpose.
Adding "fi" eliminates the symptoms but not the reason. The reason is code formatting. Compare original version: https://github.com/rockdrilla/debian-wine/blob/909e89b15464830946c36126b185de606ac2b446/debian/scripts/wine and rewritten version: https://github.com/rockdrilla/debian-wine/blob/1ba97892f23a5ae37dddb0ec89faea057959dbc9/debian/scripts/wine In my opinion, my script looks a little cleaner and clearer than the original. Besides, I have never encountered this bug - just saw your bug report and decided to help. -- SY, Konstantin Demin -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
