Bug#759079: [pkg-x2go-devel] Bug#759079: pyhoca-gui: patch for wxPython 3.0

[Mike Gabriel]

Hi Olly

On  Sa 20 Sep 2014 09:02:51 CEST, Olly Betts wrote:

On Sat, Sep 20, 2014 at 08:37:12AM +0200, Mike Gabriel wrote:

Once this segfault issue has been fixed, the upstream release is due.
I haven't had time to investigate this, yet. Any input from your side
(with more wx expertise than mine) will be appreciated.

I can certainly take a look.

  o get pyhoca-gui 0.4.0.9-1 from unstable
  o apply pyhoca-gui-0.4.0.9-1.1-nmu.diff
  o switch debian/source/format to 1.0
  o run debuild -uc -us on the patch pyhoca-gui source folder

I then tried running pyhoca-gui and it worked... But...

Then I removed python-wxgtk2.8 (which was still installed on my system).

And then I had to patch /usr/bin/pyhoca-gui a little more:

--- pyhoca-gui.broken   2014-09-25 02:28:12.139142075 +0200
+++ pyhoca-gui  2014-09-25 02:28:54.962855543 +0200
@@ -70,6 +70,10 @@

 try:
     import wxversion
+    wxversion.select('3.0')
+except: pass
+try:
+    import wxversion
     wxversion.select('2.9')
 except: pass
 try:

I actually would be really glad about that. Here is what I did with the patch you sent in:

Can you confirm that pyhoca-gui 0.4.0.9 with you patch attached to
this bug comes up without segfault?

I didn't segfault on me - I wasn't able to figure out how to set it up
to really test it, but it started up OK.

So, wxpython3.0 breaks pyhoca-gui. And I don't know why.

And after I performed all the steps, PyHoca-GUI 0.4.0.9-1.1 segfaulted for me, as well. Just like the 0.5.0.0 version we have in the nightly builds.

You can test pyhoca-gui 0.5.0.0 (preview) via this DebURL [3].

Are these the source packages I should be looking at (dated Sep 15th):

http://packages.x2go.org/debian/pool/heuler/p/pyhoca-gui/

Yes.

[1] http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=3f6545b82aeee842ada53a79e4583a3d09da562d

In 2.8, wx.InitAllImageHandlers() is a no-op, so since you require at
least 2.8 (via wxversion), there's no point having this special check -
you can just drop the call to wx.InitAllImageHandlers() entirely:

-wx.InitAllImageHandlers()
+if wx.__version__.startswith('2.')
+    wx.InitAllImageHandlers()

And similarly, wx.FD_OPEN, etc work in 2.8, so this version check isn't
necessary:

+        if wx.__version__.startswith('2.'):
+            _style = wx.OPEN | wx.CHANGE_DIR
+        else:
+            _style = wx.FD_OPEN | wx.FD_CHANGE_DIR

If you wanted to support 2.6, you'd probably need both of these version
checks, but the calls to wxversion.select(['3.0', '2.9', '2.8']) mean
the code won't run under 2.6 anyway.

The code as it is after that commit should work - it's just
unnecessarily complicated.

I'd really appreciate, if you could take a deeper look.

Can you also check:

   When you tested pyhoca-gui 0.4.0.9-1.1 (with your patch on), do you
   have python-wxgtk2.8 still installed?

Greets,
Mike



--

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

I have committed the proposed changes. But, of course, pyhoca-gui 0.5.0.0 (preview) still segfaults.

pgp2XfFiDHAo1.pgp
Description: Digitale PGP-Signatur