Your message dated Mon, 22 Sep 2014 15:23:28 +0000 with message-id <e1xw5sa-0004oa...@franck.debian.org> and subject line Bug#761114: fixed in network-manager 0.9.10.0-2.1 has caused the Debian Bug report #761114, regarding network-manager: erroneously removes externally provided routes to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 761114: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=761114 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: network-manager Version: 0.9.10.0-2 Severity: serious Tags: patch Justification: breaks unrelated software Hello, When using unrelated software, such as openvpn, that pushes default routes, network-manager immediately (and incorrectly) removes that route. This is new behavior in 0.9.10, it does not do this in previous versions. I spent quite a bit of time debugging this issue with upstream NM people on their IRC channel, in the end they came up with a patch that was committed upstream in git with the following hash: 06703c1670d0f96834b268920b09792e22fdb4c4) I tested this change, and it worked well for me, previously I uploaded a NMU, with this patch, thinking that this was #755015, and it successfully fixed the problem for me and others I know who are experiencing this issue. However, the NMU was not acknowledged in -2, due to it being targeted for the incorrect bug number. Considering that this effectively breaks all OpenVPN setups (and other software that modifies default routes) that are not using network-manager's built-in VPN mechanisms, this seems to me a serious regression over previous versions. Seeing as upstream has acknowledged this issue and provided a fix for it and that fix has been tested and even migrated to testing, it seems to me appropriate to cherry-pick the change in the package without waiting for the next major release of NM. I'm happy to re-NMU this fix, this time with the right bug number. Attached is the NMU diff (I'd only add the bug number to the changelog). micah -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.14-2-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.utf8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages network-manager depends on: ii adduser 3.113+nmu3 ii dbus 1.8.6-2 ii init-system-helpers 1.21 ii isc-dhcp-client 4.3.1-1 ii libc6 2.19-10 ii libdbus-1-3 1.8.6-2 ii libdbus-glib-1-2 0.102-1 ii libgcrypt11 1.5.4-3 ii libglib2.0-0 2.40.0-5 ii libgnutls-deb0-28 3.3.7-2 ii libgudev-1.0-0 208-8 ii libmm-glib0 1.2.0-1 ii libndp0 1.4-1 ii libnewt0.52 0.52.17-1 ii libnl-3-200 3.2.24-2 ii libnl-genl-3-200 3.2.24-2 ii libnl-route-3-200 3.2.24-2 ii libnm-glib4 0.9.10.0-2 ii libnm-util2 0.9.10.0-2 ii libpam-systemd 208-8 ii libpolkit-gobject-1-0 0.105-6.1 ii libreadline6 6.3-8 ii libsoup2.4-1 2.46.0-2 ii libsystemd-daemon0 208-8 ii libsystemd-login0 208-8 ii libteamdctl0 1.12-1 ii libuuid1 2.20.1-5.8 ii lsb-base 4.1+Debian13 ii policykit-1 0.105-6.1 ii udev 208-8 ii wpasupplicant 1.1-1 Versions of packages network-manager recommends: ii crda 3.13-1 ii dnsmasq-base 2.71-1 ii iptables 1.4.21-2 ii modemmanager 1.2.0-1 ii ppp 2.4.6-2 Versions of packages network-manager suggests: ii avahi-autoipd 0.6.31-4 pn libteam-utils <none> -- Configuration Files: /etc/NetworkManager/NetworkManager.conf changed: [main] plugins=ifupdown,keyfile [ifupdown] managed=false [logging] -- no debconf informationdiff -Nru network-manager-0.9.10.0/debian/changelog network-manager-0.9.10.0/debian/changelog --- network-manager-0.9.10.0/debian/changelog 2014-07-10 00:49:54.000000000 -0400 +++ network-manager-0.9.10.0/debian/changelog 2014-08-11 12:37:33.000000000 -0400 @@ -1,3 +1,11 @@ +network-manager (0.9.10.0-2.1) unstable; urgency=medium + + * Non-maintainer upload. + * Pull patch from upstream to fix checks for default + routes + + -- Micah Anderson <mi...@debian.org> Mon, 11 Aug 2014 12:08:31 -0400 + network-manager (0.9.10.0-2) unstable; urgency=medium * New upstream release. diff -Nru network-manager-0.9.10.0/debian/patches/0006-Fix-checks-for-default-routes network-manager-0.9.10.0/debian/patches/0006-Fix-checks-for-default-routes --- network-manager-0.9.10.0/debian/patches/0006-Fix-checks-for-default-routes 1969-12-31 19:00:00.000000000 -0500 +++ network-manager-0.9.10.0/debian/patches/0006-Fix-checks-for-default-routes 2014-08-11 12:37:08.000000000 -0400 @@ -0,0 +1,83 @@ +Index: network-manager-0.9.10.0/src/nm-ip4-config.c +=================================================================== +--- network-manager-0.9.10.0.orig/src/nm-ip4-config.c 2014-07-03 20:44:19.000000000 -0400 ++++ network-manager-0.9.10.0/src/nm-ip4-config.c 2014-07-29 19:42:06.965378158 -0400 +@@ -198,7 +198,7 @@ + for (i = 0; i < priv->routes->len; i++) { + const NMPlatformIP4Route *route = &g_array_index (priv->routes, NMPlatformIP4Route, i); + +- if (route->network == 0) { ++ if (NM_PLATFORM_IP_ROUTE_IS_DEFAULT (route)) { + if (route->metric < lowest_metric) { + priv->gateway = route->gateway; + lowest_metric = route->metric; +@@ -276,7 +276,8 @@ + /* Don't add the default route if the connection + * is never supposed to be the default connection. + */ +- if (nm_ip4_config_get_never_default (config) && route.network == 0) ++ if ( nm_ip4_config_get_never_default (config) ++ && NM_PLATFORM_IP_ROUTE_IS_DEFAULT (&route)) + continue; + + g_array_append_val (routes, route); +Index: network-manager-0.9.10.0/src/nm-ip6-config.c +=================================================================== +--- network-manager-0.9.10.0.orig/src/nm-ip6-config.c 2014-07-03 20:44:19.000000000 -0400 ++++ network-manager-0.9.10.0/src/nm-ip6-config.c 2014-07-29 19:42:06.965378158 -0400 +@@ -308,7 +308,7 @@ + for (i = 0; i < priv->routes->len; i++) { + const NMPlatformIP6Route *route = &g_array_index (priv->routes, NMPlatformIP6Route, i); + +- if (IN6_IS_ADDR_UNSPECIFIED (&route->network)) { ++ if (NM_PLATFORM_IP_ROUTE_IS_DEFAULT (route)) { + if (route->metric < lowest_metric) { + priv->gateway = route->gateway; + lowest_metric = route->metric; +@@ -387,7 +387,8 @@ + /* Don't add the default route if the connection + * is never supposed to be the default connection. + */ +- if (nm_ip6_config_get_never_default (config) && IN6_IS_ADDR_UNSPECIFIED (&route.network)) ++ if ( nm_ip6_config_get_never_default (config) ++ && NM_PLATFORM_IP_ROUTE_IS_DEFAULT (&route)) + continue; + + g_array_append_val (routes, route); +Index: network-manager-0.9.10.0/src/platform/nm-linux-platform.c +=================================================================== +--- network-manager-0.9.10.0.orig/src/platform/nm-linux-platform.c 2014-07-03 20:44:19.000000000 -0400 ++++ network-manager-0.9.10.0/src/platform/nm-linux-platform.c 2014-07-29 19:42:06.969378050 -0400 +@@ -3520,7 +3520,7 @@ + for (object = nl_cache_get_first (priv->route_cache); object; object = nl_cache_get_next (object)) { + if (_route_match ((struct rtnl_route *) object, AF_INET, ifindex)) { + if (init_ip4_route (&route, (struct rtnl_route *) object)) { +- if (route.plen != 0 || include_default) ++ if (!NM_PLATFORM_IP_ROUTE_IS_DEFAULT (&route) || include_default) + g_array_append_val (routes, route); + } + } +@@ -3542,7 +3542,7 @@ + for (object = nl_cache_get_first (priv->route_cache); object; object = nl_cache_get_next (object)) { + if (_route_match ((struct rtnl_route *) object, AF_INET6, ifindex)) { + if (init_ip6_route (&route, (struct rtnl_route *) object)) { +- if (route.plen != 0 || include_default) ++ if (!NM_PLATFORM_IP_ROUTE_IS_DEFAULT (&route) || include_default) + g_array_append_val (routes, route); + } + } +Index: network-manager-0.9.10.0/src/platform/nm-platform.h +=================================================================== +--- network-manager-0.9.10.0.orig/src/platform/nm-platform.h 2014-07-03 20:44:13.000000000 -0400 ++++ network-manager-0.9.10.0/src/platform/nm-platform.h 2014-07-29 19:41:45.549955242 -0400 +@@ -248,6 +248,10 @@ + }; + } NMPlatformIPRoute; + ++#define NM_PLATFORM_IP_ROUTE_IS_DEFAULT(route) \ ++ ( ((const NMPlatformIPRoute *) (route))->plen <= 0 ) ++ ++ + typedef struct { + __NMPlatformIPRoute_COMMON; + in_addr_t network; diff -Nru network-manager-0.9.10.0/debian/patches/series network-manager-0.9.10.0/debian/patches/series --- network-manager-0.9.10.0/debian/patches/series 2014-07-10 00:49:54.000000000 -0400 +++ network-manager-0.9.10.0/debian/patches/series 2014-08-11 12:37:21.000000000 -0400 @@ -3,3 +3,4 @@ 0003-Don-t-setup-Sleep-Monitor-if-not-booted-with-systemd.patch 0004-Use-symlinks-for-nmtui.patch 0005-Mark-virtual-ethernet-interfaces-as-unmanaged.patch +0006-Fix-checks-for-default-routes
--- End Message ---
--- Begin Message ---Source: network-manager Source-Version: 0.9.10.0-2.1 We believe that the bug you reported is fixed in the latest version of network-manager, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 761...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Micah Anderson <mi...@debian.org> (supplier of updated network-manager package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Wed, 17 Sep 2014 10:06:10 -0400 Source: network-manager Binary: network-manager network-manager-dev libnm-glib4 libnm-glib-dev libnm-glib-vpn1 libnm-glib-vpn-dev libnm-util2 libnm-util-dev network-manager-dbg gir1.2-networkmanager-1.0 Architecture: source amd64 Version: 0.9.10.0-2.1 Distribution: unstable Urgency: medium Maintainer: Utopia Maintenance Team <pkg-utopia-maintain...@lists.alioth.debian.org> Changed-By: Micah Anderson <mi...@debian.org> Description: gir1.2-networkmanager-1.0 - GObject introspection data for NetworkManager libnm-glib-dev - network management framework (GLib interface) libnm-glib-vpn-dev - network management framework (GLib interface) libnm-glib-vpn1 - network management framework (GLib VPN shared library) libnm-glib4 - network management framework (GLib shared library) libnm-util-dev - network management framework (development files) libnm-util2 - network management framework (shared library) network-manager - network management framework (daemon and userspace tools) network-manager-dbg - network management framework (debugging symbols) network-manager-dev - network management framework (development files) Closes: 761114 Changes: network-manager (0.9.10.0-2.1) unstable; urgency=medium . * Non-maintainer upload. * Cherry-pick upstream commit to fix checks for default routes (Closes: #761114) Checksums-Sha1: 3c71ba8d9ba1dade63f0e4397fa1767fb5e11046 3542 network-manager_0.9.10.0-2.1.dsc dd5e058e889356f5b2f6bf100a3f481aa7ce52ea 38640 network-manager_0.9.10.0-2.1.debian.tar.xz 605e1869fbb078bd09de34c908c6dae968faf4e2 1438248 network-manager_0.9.10.0-2.1_amd64.deb 83ae40a052fec2c1ebc48e1983b2aa1999fd6906 286726 network-manager-dev_0.9.10.0-2.1_amd64.deb 8b69806cafce5d66bfc8808327687e28a153271c 316468 libnm-glib4_0.9.10.0-2.1_amd64.deb b55649b2a4a9a698dd92b1bea864f53213dd46f5 427320 libnm-glib-dev_0.9.10.0-2.1_amd64.deb 0bfe06afe6325018b501a45eedcd5a2208902338 244440 libnm-glib-vpn1_0.9.10.0-2.1_amd64.deb e92cb5dfc81b5b2db52bcdcf7036a049ba494a05 235954 libnm-glib-vpn-dev_0.9.10.0-2.1_amd64.deb c43e4a5ed7b911a1a29e9f46683770778be89e00 364092 libnm-util2_0.9.10.0-2.1_amd64.deb 1fd007bb1e9ae3e90841128302bc311a369937bf 420984 libnm-util-dev_0.9.10.0-2.1_amd64.deb 0b222c6d9e0e29b080e32e4325bb088ebf2c15aa 2864900 network-manager-dbg_0.9.10.0-2.1_amd64.deb 8e7e3265098dd1517394c4ce779fe49c37b9770b 269176 gir1.2-networkmanager-1.0_0.9.10.0-2.1_amd64.deb Checksums-Sha256: e5fa270ff6d154fa63717387bafd30574c26a2e0e8da72f2f8363dd7523ea11a 3542 network-manager_0.9.10.0-2.1.dsc bbd819df2ea17ed84367f430e96f395adf123e62bade5edaf7b17756bcebf6e2 38640 network-manager_0.9.10.0-2.1.debian.tar.xz 56121ea6d43777198f34dcb56d7aae8dff068452ebb83ca356cbe459b1a3c744 1438248 network-manager_0.9.10.0-2.1_amd64.deb 693ffec2cd6da4b92e0f4eed37535058e45aece28dcad1ea3f612d4a73476bfb 286726 network-manager-dev_0.9.10.0-2.1_amd64.deb fb42cd50c013d1ce3df98d7ed81700ec324ffc40c258adb1805c54a22d777376 316468 libnm-glib4_0.9.10.0-2.1_amd64.deb 9dbf1078b071f7c37a48e5e930cf3bc81c38f8e19365c18bbb9eafc1de14d1bf 427320 libnm-glib-dev_0.9.10.0-2.1_amd64.deb 291b013e034e8956952e325806b5dd60f768709c24f4fdab0868f6e5d42c9ca1 244440 libnm-glib-vpn1_0.9.10.0-2.1_amd64.deb 21837a3108d5bf6c3f95f05b0801072ea4269d09110c0f2beb157d419ba3e0c7 235954 libnm-glib-vpn-dev_0.9.10.0-2.1_amd64.deb 4ac50bcd2522c5f091d4ea09998b008a23cf0121593a6e6488fcd1ff2509c50a 364092 libnm-util2_0.9.10.0-2.1_amd64.deb 4cac8c0d4b31bab10d0e0c2849b0430982725aa019b118a69b6a8c86adb9e7fb 420984 libnm-util-dev_0.9.10.0-2.1_amd64.deb 40d55ba1cec76cd028bce22606fe1998d60fa65225d3be850db876f5b9e019e7 2864900 network-manager-dbg_0.9.10.0-2.1_amd64.deb 4c60095337ff07e9f0be96211e2f66b2b9faa0ff59106819b10065ddff86387c 269176 gir1.2-networkmanager-1.0_0.9.10.0-2.1_amd64.deb Files: 57c2839d9fac71e63ad2284885be72dc 1438248 net optional network-manager_0.9.10.0-2.1_amd64.deb 8f211dce7adf33e6c598e1056aaa792e 286726 devel optional network-manager-dev_0.9.10.0-2.1_amd64.deb ae56021db390a9a8e43fbd408c2efddd 316468 libs optional libnm-glib4_0.9.10.0-2.1_amd64.deb c130b3d1a9cef624b551277fa71e6bad 427320 libdevel optional libnm-glib-dev_0.9.10.0-2.1_amd64.deb 775e4ae47c024d000314be354fc34672 244440 libs optional libnm-glib-vpn1_0.9.10.0-2.1_amd64.deb 3803929dc2c55e217d584376071ea6af 235954 libdevel optional libnm-glib-vpn-dev_0.9.10.0-2.1_amd64.deb 86d5b34bb553f861a4a1ee6de75b55af 364092 libs optional libnm-util2_0.9.10.0-2.1_amd64.deb 94d88fb443259112d7166cd6293cb830 420984 libdevel optional libnm-util-dev_0.9.10.0-2.1_amd64.deb de70a642ccfbef9ca1564aea167bc501 2864900 debug extra network-manager-dbg_0.9.10.0-2.1_amd64.deb 5343359e897d839e104b1e5c002f7c37 269176 introspection optional gir1.2-networkmanager-1.0_0.9.10.0-2.1_amd64.deb 738b5ff5eef12e68b01b79736ce68d5f 3542 net optional network-manager_0.9.10.0-2.1.dsc 6159efaf6aa1f4d8eb3ac6b38281c773 38640 net optional network-manager_0.9.10.0-2.1.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJUGZi+XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0Nzc3NTM1RkU1NDcxNTYyNjI2MDc3QjU4 Q0JGOUEzMjI4NjFBNzkwAAoJEIy/mjIoYaeQqUcP/1OSAqNOUHEngtgicEX7Xu5c vlGDYIzZbkq3tX5teRfoCfVvh2k19lbTou6tMUwGFiY8GGYoKf0vWLQx5RZMn3/7 qj9Gqd46WqFT7np0pbY7AEH+6Vi8Y6Lf0ns6xW/lANHzTMdrIBBKGRsL+dkHcnt7 c9AdVZkwVmoR8xCgdMiQBP0jF1uayL/mKKxmju/8HV370VQNMkmOlMI4KzIJzwdD Qc9A9d6n8ToMqmGX3Dk2K8L/wimnGZNZCop8zzOqjs4bFcs3A3Aha4rpf0PN9P3z yGfcAu7MGyiOYjJuC4SpEbuiu3labmuCtc47tO+qup76oevRfswSJR5CgKhlwtKa tMxlYY1uJWuI+h74QkDkHu0UK9DE1PsenOPIL5+tuHpzazAVV8rFIAa1/OkrKPuD Q3pcgKBvi9jzX3tK8LTDEei45dSQwjrAY/Aw5JdrjrtPnk+Wrb4/uDNOs7CA1I/O DdEAX6fEt13Js5vf1bC6f/FbLKDznXr4215qEyqlVR7S7DXlqf4oqzQp5jf+hHB5 PsoVvQnggwfdN4WvEoVrArie1w3w1NguaCB4gTReG+EeHTy2ghbVTePFm9oitsoq LlNXgzfONbWmLg55Zo7KHSazJafmdTpq5hkcVkQWaJhQcrmqBnG1C1fbS268k+M0 FCE5bS60pGxFyHWPuCPc =M/pv -----END PGP SIGNATURE-----
--- End Message ---
