On Mon, Sep 08, 2014 at 11:30:48PM -0300, Felipe Sateler wrote:
> Could you propose a patch filtering out the characters plus (+), minus
> (-) signs, and periods (.)?

Sure, revised patch is attached.

Regards
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
diff -Nru cdbs-0.4.126/1/class/langcore.mk.in cdbs-0.4.126simon1/1/class/langcore.mk.in
--- cdbs-0.4.126/1/class/langcore.mk.in	2014-08-21 20:44:42.000000000 +0200
+++ cdbs-0.4.126simon1/1/class/langcore.mk.in	2014-09-09 15:23:00.000000000 +0200
@@ -24,12 +24,21 @@
 
 # Resolve our defaults
 ifneq (,$(wildcard /usr/bin/dpkg-buildflags))
+# $(filter-out %x%,...) doesn't work ...
+_filter_out = $(foreach v,$(2),$(if $(findstring $(1),$(v)),,$(v)))
 # GNU Make doesn't export current environment in $(shell ..) function.
 # We need at least some of the DEB_* flags for dpkg-buildflags, so
 # extract them from the defined variables.  Sadly there seems to be no
 # way to get just get all exported variables.
+#
+# Make variables containing the characters "+ - ." need to be filtered out as
+# they can't be exported as shell variables, see #712729.
 _get_dpkg_buildflags = $(shell \
-	$(foreach flag,$(filter DEB_%,$(.VARIABLES)),\
+	$(foreach flag,\
+			$(call _filter_out,+,\
+			$(call _filter_out,-,\
+			$(call _filter_out,.,\
+			$(filter DEB_%,$(.VARIABLES))))),\
 		$(flag)="$($(flag))") \
 	dpkg-buildflags --get $(1))
 deb_cflags := $(call _get_dpkg_buildflags,CFLAGS)

Attachment: signature.asc
Description: Digital signature

Reply via email to