On Sat, Sep 06, 2014 at 11:01:29AM +0300, Andrii Senkovych wrote: > Closing the by by agreement with the reporter. The bug cannot be > reproduced on several buildbot instances on the maintainer's machine > and the end user's problem has been resolved.
I had the same problem unfortunately and I think this is a really bad
upgrade experience, so in case someone else finds this bugreport in
a "what the hell, why isn't that working…" moment (or maybe it even
helps the maintainer reproducing it, who knows):
"Funnily" simply deleting the state.sqlite file didn't change anything,
I just got a new empty state.sqlite file (with the "wrong" owner 'root'
as all the other files are owned by the 'buildbot' user – maybe the
message should indicate how to run the upgrade command as another user
than root), but the message remained the same. What helped was in fact
correcting what the upgrade-master command complained about in the
warning (as in the initial mail): "WARNING: rotateLength is a string, it
should be a number"
I can't remember ever touching the buildbot.tac file at all, but well,
I had these values in the file:
rotateLength = '10000000'
maxRotatedFiles = '10'
[possibly upstream bug #2588 ; my instance was setup in January 2014]
After removing the quotes from both (after fixing rotateLength you get
the same warning about maxRotateFiles) I could run the upgrade-master
command and it finished successfully. These should really be errors
instead of warnings if they make the command fail completely…
Trying to start buildmaster again made it die without any message in the
logs though, but the upgrade command had created a new master.cfg.sample
file and comparing this with my file indicated that the way the port has
to be set changed – notice that I haven't changed the port at all…
anyway, changing the old line to:
c['protocols'] = {'pb': {'port': 9989}}
made the buildmaster start again with all of its old state.
Sidenote: In public_html/ there are also some *.new files for me,
namely for robots.txt and default.css – I doubt I had changed them
either, so at least default.css would have been nice if it was upgraded
automatically (I see why robots.txt wasn't) [even better if it would be
handled like the template files as I have no intension of changing the
CSS], but at least a friendly message that I should do that would be
good.
Best regards
David Kalnischkies
signature.asc
Description: Digital signature
