Your message dated Tue, 02 Sep 2014 22:49:26 +0000 with message-id <e1xowtc-0003z3...@franck.debian.org> and subject line Bug#662221: fixed in nautic 1.5-1.1 has caused the Debian Bug report #662221, regarding FTBFS: src/Makefile.am: 'automake --add-missing' can install 'depcomp' to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 662221: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=662221 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: nautic Version: 1.3-6 Severity: serious Justification: Broken use of source format, poor packaging rules I came across nautic because there is a release-critical bug applied to the package which is still open but it looks as if the package has been fixed. Upon reviewing the package, I found a number of problems. 0: The debian/changelog needs to actually describe the changes - not "adjustments". The changelog also needs to be updated using debchange with the --closes argument to say which bugs are being closed. This would have prevented bug #637689 from still being open. 1: lintian warnings should be fixed and the ones in this package are simple to fix. 2: One of the lintian warnings relates to the patches which are, actually, completely unnecessary. A few changes to debian/rules and the patches go away. There is never a need to patch generated files and your package should have been regenerating Makefile.in anyway. There never was any need for the package to contain ltmain.sh, let alone change it in a patch, as no library is being built. 3: The watch file does not work but is simple to fix. 4: There is an upstream version which only adds to the problems because it is a different file: 1.3.orig.tar.gz The original tarball checksums can be seen here: http://packages.qa.debian.org/n/nautic/news/20110812T190307Z.html 3c06aff06312b4b616af20eb227d46849638a64e7a2a8966011ff7a6ea12cc0e 407867 nautic_1.3.orig.tar.gz The tarball I downloaded from SF for the 1.3-7 version DIFFERS: 205039e6e515126be22c8b3d3daed8fc8cb0f5cb80594a0196eeeffc7e73f051 nautic_1.3.orig.tar.gz Those MUST be the same file. If you change ANYTHING which goes into the upstream (.orig.tar.gz) tarball at SourceForge, you make a new upstream release which will be 1.4-1 not 1.3-7. Otherwise, your 1.3-7 upload to Debian will be either rejected or will simply not contain what you expect. i.e. the changes made in upstream include: src/about.cpp | 2 - src/un_known_star.cpp | 18 +++++------------ If you had uploaded 1.3-7 in that state, it would have been compiled without these changes. It is also unnecessary to repack the nautic tarball just to set the directory name to package-version, the tools work with that without problems. Frankly, nautic is in such a bad state for the packaging that I was close to asking for the removal of the package and I am very unclear on whether the package should be allowed to migrate into testing. For now, this bug will replace the original RC bug to keep nautic out of testing. Please fix this package properly, talk to people on debian-ment...@lists.debian.org and ask for a review of the package as it currently is in the archive. Version 1.3-6 is NOT in a satisfactory state in Debian. You should also take down 1.3-7 from sourceforge and redo it as 1.4 (without the debian version), taking advice from debian-mentors to fix all of the issues before the next upload. If you are at all unclear then seek a package review by a sponsor using the debian-mentors mailing list. My changes to make a more suitable package result in these changed files: $ cat debian/watch version=3 http://sf.net/nauticalmanac/nautic_(.+)\.orig\.tar\.gz $ cat debian/rules #!/usr/bin/make -f # -*- makefile -*- # Sample debian/rules that uses debhelper. # This file was originally written by Joey Hess and Craig Small. # As a special exception, when this file is copied by dh-make into a # dh-make output file, you may use that output file without restriction. # This special exception was added by Craig Small in version 0.37 of dh-make. # Uncomment this to turn on verbose mode. #export DH_VERBOSE=1 %: dh $@ override_dh_clean: dh_clean rm -f config.guess config.sub config.log config.status $(RM) ltmain.sh Makefile.in configure $(RM) aclocal.m4 data/Makefile.in icon/Makefile.in $(RM) info/Makefile.in man/Makefile.in src/Makefile.in override_dh_auto_configure: autoreconf -fs dh_auto_configure Then remove everything from debian/patches. (debian/patches is only for changes outside the debian directory and even then, not for files generated / modified by autoreconf.) One lintian warning in debian/control fixed with: Build-Depends: debhelper (>= 7.0.50~), Please note, I'm not actually sponsoring packages currently. Any further questions or problems need to be discussed with the debian-mentors mailing list.
--- End Message ---
--- Begin Message ---Source: nautic Source-Version: 1.5-1.1 We believe that the bug you reported is fixed in the latest version of nautic, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 662...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Olly Betts <o...@survex.com> (supplier of updated nautic package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Tue, 02 Sep 2014 13:11:15 +0000 Source: nautic Binary: nautic Architecture: source Version: 1.5-1.1 Distribution: unstable Urgency: medium Maintainer: Enas Giovanni <gio.e...@alice.it> Changed-By: Olly Betts <o...@survex.com> Description: nautic - computation of observer position in astro-navigation Closes: 662221 713547 750972 750974 Changes: nautic (1.5-1.1) unstable; urgency=medium . * Non-maintainer upload with maintainer's consent. . [ Hideki Yamane ] * debian/rules - Just use dh-autoreconf to fix FTBFS (Closes: #662221, #713547) * debian/control - add "Build-Depends: dh-autoreconf" . [ Olly Betts ] * Update to use wxWidgets 3.0 (Closes: #750972): - New patch: wx3.0-compat.patch * Fix a buffer overrun (Closes: #750974): - New patch: fix-buffer-overrun.patch * Update to use dh compat level 9 to enable hardening flags. * "Standards-Version: 3.9.5" - only change is to drop obsolete "DM-Upload-Allowed: yes". * Fix typo in long description. * Fix typo in "About" dialog spotted by lintian (new patch typos.patch). * Override lintian errors about symlinks pointing outside the source tree - dh_autoreconf replaces these with files. Checksums-Sha1: c530a957017ce203b21048000670e9c17250f4e4 1728 nautic_1.5-1.1.dsc e1afeff05f2b6127412aa9b2e4d2f2e769f735ec 5724 nautic_1.5-1.1.debian.tar.xz Checksums-Sha256: 9fe304e4b0fc3c020cc002cc2e9ff421517624b4f2aa77202bce62ef02d34d27 1728 nautic_1.5-1.1.dsc f245df76e1b5df7398f0a308b873e17d3855582484c7965fdb0e1d05839d2b47 5724 nautic_1.5-1.1.debian.tar.xz Files: 8345e5e1753fbf81731bc139f25e3c80 1728 science optional nautic_1.5-1.1.dsc 17cdedf20c6b985e82f0be5f3ea50a33 5724 science optional nautic_1.5-1.1.debian.tar.xz -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUBkXvAAoJEBgUewc7rSsH59oQAIoH9vLIZ+P2gG+1a3RVp73+ QlPLLxR4lb2Not+YFoOzspQJSo5BIAzhAIX9iDSZeOAySsn3BpVOgZB7Y2fcAyOc pk5kQWXUob035fTSkQXz91BRw1j1LyCrKj8SXgw4tYIB9kD6TPpt4exyOO0MHwxs LUpQ5mr8w0XgwLE+vf+FraZinF8JPj2DT9hq4CY/Qdk1JgEd3fvJ7Fr/4/5sh0V2 xWSJPWm94sxxFYFcefb7s4enCiGwLbOIv8tkPpM+naNgoYV4nEfOeZi1juJ2zBgp SzSkhz6GchuXMKSJpog7koi1t/xrJ1DErnFQmBbf+VmcNtUogGwl9bzhSx70cUl9 dpdIiqbJFTNS9g3x7r6iRx0AA/qlMkPHSgUL8hUjnnLkFnA18m98BM/wP1G3fCc4 hCjmQu2PbMymuSrydag6qoKF28XSbSz4UBqjAgWUQB+olj7plvhYAunvve76V52b v7yhadf2+ZKliBNNHXK3RMkFfPQTIUr+xUbEyYLFw2arOB0O16R/GjBmHIu/k2+r ikcV0GwoKKemqtF/4QMMWACpemIyYU4WAnWrfkNqJHUneTd995uixM1TgN1Vm4gj U8y5Tc7yYnk9/precvq+eDhLppB2scGoOPO+jH87WzCCI0fT5yG0UrXvix6xIcNL rrpfU6Cdb7nwGuGd50O4 =aoRY -----END PGP SIGNATURE-----
--- End Message ---
